GH actions from upstream Kargo now pass#4
Merged
Merged
Conversation
Signed-off-by: Seth Nickell <snickell@gmail.com>
Signed-off-by: Seth Nickell <snickell@gmail.com>
Signed-off-by: Seth Nickell <snickell@gmail.com>
snickell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the fork-specific CI breakage that showed up after bringing in upstream Kargo. The goal is simple: keep upstream Actions working on
code-dot-org/kargo-extendedwith the minimum necessary divergence from upstream files.Technical changes:
check-codegenin.github/workflows/ci.yamlto use$GITHUB_WORKSPACEinstead of an upstream-only checkout pathextended/inDockerfileso the image build can compile the fork-owned StepPlugin packages used by controlplaneWith these fixes in place, the upstream CI workflow passes on this fork again.