Fix invalid speed measurements and bound test runs - #304
Open
code-inflation wants to merge 1 commit into
Open
Conversation
code-inflation
force-pushed
the
fix/p1-measurement-correctness
branch
from
September 13, 2026 07:42
55b6a2f to
2d5235f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incomplete downloads could be counted as full transfers, HTTP error responses could become latency samples, and runs with no successful throughput measurements could exit successfully. This change validates measurements and gives runs explicit outcomes and bounded execution.
The CLI adds
--max-duration,--max-retry-wait, and--server. Exit codes are 0 for complete, 1 for failed, 3 for partial, and 130 for cancellation. An in-flight blocking request may finish at its remaining request timeout before cancellation completes.Compatibility: existing successful measurement fields and CSV columns remain available. JSON adds run status, stop reason, and structured errors. Legacy latency wrappers return NaN rather than zero when no valid measurement exists;
fetch_metadatareturnsMeasurementErrorto represent metadata validation failures. README documents these changes.Validation: