Skip to content

Remove gates #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Remove gates #253

merged 10 commits into from
Oct 2, 2024

Conversation

JWittmeyer
Copy link
Member

@JWittmeyer JWittmeyer commented Sep 9, 2024

k8 Cluster PRs:

Notes

(After switching dev setup branch) best to start with: bash start -a -b remove-gates

Removed

  • commercial proxy => was introduced for gates
  • api token in refinery => only for gates/commercial proxy
  • welcome screen => not in use anymore / on removal list
  • platform-monitoring => not in use anymore / on removal list
  • step type retrieval => connects to gates
  • step type question enrich => connects to gates
  • sync with refinery => works with gates
  • cognition project -> refinery project ids & sync fields => not relevant anymore
  • wizard code in cognition => not used anymore / needs a new wizard for the new structure if wanted

Checked production DB => nothing to do

  • model callbacks (table record_label_association)
  • type heuristic for CROWD_LABELER & ZERO_SHOT (table information_source)
  • removed step type for retrieval (not necessary if the migration from our SOs works -> added to check in release PR)
  • comment data
  • [ ]

ToDo

  • remove alembic tmp code before mergin to dev
  • changes for production PR
  • changes for k8 (see above)
  • There seems to be a redirect from base origin (e.g. http://localhost:4455/) to /welcome => couldn't find yet where
  • add note to delete models downloaded before release in production PR
  • delete zero shot from app version
  • add project shell import/export
  • remove refinery-commercial-proxy from app version (if not used anymore)

@lumburovskalina
Copy link
Contributor

Documentation for gates needs to be removed: https://docs.kern.ai/gates

  • resolved
  • add to the points on the bottom as not urgent now

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Sep 13, 2024

Not sure if related to this (or removal the project wizard), but i tested Neural search with a Clickbait sample project in refinery and the embeddings from the project itself are not directly shown in the neural search.

  • resolved
  • ignored

Lina: I tested this and it works fine if the embedding is recreated, or if other embedding is added. I think this is an expected behaviour or? @JWittmeyer

* Removal of crowd labeler and zeroshot

* Remove zero-shot unused code

* Removed model callbacks

* Removed model callbacks on data browser and filters

* Model callback removal

* Users filter removed on data browser

* Removed label studio

* Remove doc_ock from refinery
@JWittmeyer JWittmeyer marked this pull request as ready for review October 2, 2024 09:00
@JWittmeyer JWittmeyer merged commit 9ddadfd into dev Oct 2, 2024
5 checks passed
@JWittmeyer JWittmeyer deleted the remove-gates branch October 2, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants