feat(writing): add non-coding writer category and skills#2259
feat(writing): add non-coding writer category and skills#2259ilovingjny wants to merge 3 commits into
Conversation
|
All contributors have signed the CLA. Thank you! ✅ |
34d6127 to
4e55bdb
Compare
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Purely additive change that registers a new 'scribe' agent; does not modify existing agent logic or core orchestration, ensuring no regressions to existing functionality.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/guide/agent-model-matching.md">
<violation number="1" location="docs/guide/agent-model-matching.md:67">
P1: The documented model fallback chain for the Scribe agent does not match the actual implementation in `src/shared/model-requirements.ts`. Documentation states `Kimi K2.5 → GLM 5 → Claude Sonnet → GPT-5.2`, but the actual implementation is `Claude Sonnet → Kimi K2.5 → Gemini 3 Flash → GPT-5.2`. Update the documentation to reflect the actual implementation.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
[sisyphus-bot] PR sweep status check on
Approved but blocked on merge conflicts. Please rebase onto current Assigning |
|
[sisyphus-bot] Hi ilovingjny. 🙏 Thanks for the Scribe document-writer agent. Picking this back up from the 5/16 approval. The PR is small (147/0 across 5 files) and shows CONFLICTING against current A focused, additive new specialized agent is a relatively low-risk addition. Could you rebase against current |
|
Thanks for picking this back up. I agree that the important distinction is between Prometheus as a planning/spec agent and Scribe as a prose-production agent. My intended boundary after rebasing is:
I also want to refresh the implementation to match the current One design correction from the original PR: this should be locale-aware, not Korean-only. Korean formal writing is an important motivating use case, but the general rule should be "match the user's language and document culture" so English, Chinese, Japanese, Korean, and other professional document formats can be handled consistently. I will rebase onto current |
Add a non-coding-writing delegation category plus built-in writing skills for locale-aware, official document, creative, law/policy, and product-definition prose.
b2a81cc to
9733c8f
Compare
|
Refreshed this PR against current |
Include the non-coding-writing category in generated model fallback config snapshots.
|
Follow-up update:\n\n- Updated the CLI model-fallback snapshots so the new |
There was a problem hiding this comment.
1 issue found across 31 files
Confidence score: 4/5
- This PR looks safe to merge overall, with a focused, low-to-moderate risk issue rather than a broad runtime regression.
- In
src/tools/delegate-task/tools.test.ts, a case-sensitive assertion does not match the actual prompt text ("Not pleadings"), so the test is likely to fail until the expected string is corrected. - Because the issue is confined to test expectations (severity 5/10) and not a confirmed production behavior break, the merge risk stays relatively contained.
- Pay close attention to
src/tools/delegate-task/tools.test.ts- fix the assertion text/casing mismatch to avoid CI/test failures.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
@cubic-dev-ai Thanks for catching this. Fixed the case-sensitive test expectation in Local verification: |
@ilovingjny Looks good — matching the actual prompt text is the right call. Snapshot-driven tests like that bite you exactly when casing drifts between the source template and the expectation, and your fix keeps them in sync. One suggestion: if the Tip: get faster answers by chatting with cubic’s review copilot in the review UI |
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: This PR cleanly adds a new non-coding-writing category and five companion skills with zero modifications to existing functionality, updated documentation, and passing test coverage, so there is no risk of regression.
Re-trigger cubic
eb25d29 to
2bfad49
Compare
Summary
Refreshes #2234 against current
devby implementing the non-coding writer as category + skills instead of a standalone Scribe agent.non-coding-writing, a built-in category for reports, proposals, official correspondence, policy documents, creative prose, and product-definition writing.writingcategory focused on technical documentation and developer prose.locale-aware-writing,official-document-writing,creative-writing,law-policy-writing, andproduct-definition-writing.non-coding-writingwith the relevant writing skills.Why this fits OmO
This aligns with OmO's philosophy that users should not need to manually pick the most expensive model or provider to get high-quality work. For prose-first tasks, quality often comes from the right routing, the right prompt surface, locale-aware conventions, and a suitable fallback model chain. A dedicated
non-coding-writingcategory lets OmO apply that same orchestration philosophy to reports, official documents, policy writing, creative prose, law-and-policy analysis, and product-definition documents.This is not about downgrading writing tasks to cheaper models. It is about making writing tasks model-fit-aware: some prose tasks need a communicative Claude/Kimi-style model, some need GPT-style reasoning, and some can use a faster lightweight fallback. The category and skill layer lets OmO make that choice automatically instead of forcing the user to guess.
Boundary
Prometheus remains the interview/planning/specification agent. This PR does not add another planner and does not grant prose-writing tasks code-editing or shell-oriented behavior.
law-policy-writingis intentionally limited to public, analytical, institutional, or reform-oriented writing. It is not for pleadings, court filings, litigation strategy, demand letters, or client-specific legal advice.The feature is locale-aware, not Korean-only. Korean formal documents remain a motivating use case, but the rule is to match the user's language, register, and document culture.
If this feels too broad for one PR, I am happy to keep the core
non-coding-writingcategory pluslocale-aware-writing,official-document-writing, andlaw-policy-writinghere, then splitcreative-writingandproduct-definition-writinginto follow-up PRs.Test plan
bun test src/model-requirements.test.tsfrompackages/model-corebun --config=/tmp/empty-bunfig.toml test src/features/builtin-skills/skills.test.tsbun --config=/tmp/empty-bunfig.toml test src/config/schema.test.ts src/config/schema/agent-names.test.tsbun --config=/tmp/empty-bunfig.toml test -u src/cli/model-fallback.test.tsbun --config=/tmp/empty-bunfig.toml test src/cli/model-fallback.test.tsbun run build:schemabun run typecheckDEFAULT_CATEGORIES["non-coding-writing"]and its category prompt appendRefs #2234