fix(config): accept 'max' as valid reasoningEffort for o-series models#4514
Open
Hungdoan565 wants to merge 2 commits into
Open
fix(config): accept 'max' as valid reasoningEffort for o-series models#4514Hungdoan565 wants to merge 2 commits into
Hungdoan565 wants to merge 2 commits into
Conversation
Adds 'max' to the o-series (openai-reasoning) model family's reasoningEfforts heuristic array. Previously, 'max' was only recognized for gpt-5 and deepseek families, causing the model settings compatibility layer to downgrade it to 'high' for o-series models. Also adds test coverage for the 'max' value in schema validation and compatibility tests. Closes code-yeongyu#4165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 'max' to the o-series model family's supported
easoningEfforts in packages/model-core/src/model-capability-heuristics.ts. Previously, o-series models only listed ['none', 'minimal', 'low', 'medium', 'high'], causing 'max' to be silently downgraded when used with o-series models.
Changes
easoningEfforts array
easoningEffort: 'max' passes Zod schema validation
Testing
Closes #4165
Summary by cubic
Accepts
maxas a validreasoningEffortfor o-series (openai-reasoning) models so it no longer gets downgraded tohigh. Closes #4165.maxto o-seriesreasoningEffortsheuristic inpackages/model-core/src/model-capability-heuristics.ts.maxand validate schema inpackages/model-core/src/model-settings-compatibility.test.ts,packages/model-core/src/model-capabilities.test.ts, andsrc/config/schema.test.ts; bumpoh-my-opencode-*optional binaries to 4.5.1 inbun.lock.Written for commit e36fad7. Summary will update on new commits. Review in cubic