fix(skill-loader): include agentsFromOpenCodeConfig in discoverSkills#4581
Open
Hungdoan565 wants to merge 3 commits into
Open
Conversation
PR code-yeongyu#4581 introduced calls to getAgentsSkillDirs from opencode-command-dirs but never implemented it, causing TS2305 + TS7006 typecheck failures that cascaded into test compile errors. Mirror the getOpenCodeSkillDirs pattern to resolve .agents/skills dirs under each OpenCode config dir (plus profiles parent).
Hungdoan565
force-pushed
the
fix/discover-skills-missing-agents-opencode-config-4533
branch
from
9129078 to
78d74f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4533
Skills from ~/.config/opencode/.agents/skills/ were not discoverable via the skill tool because discoverSkills() was missing the call to discoverGlobalAgentsSkillsFromOpenCodeConfig().
The fix adds this function to the Promise.all array and includes its results in the deduplication step, matching the priority order already used in discoverAllSkills().
Summary by cubic
Fixes missing agent skills by discovering OpenCode-configured agents. Adds a default .gitignore to team-mode worktree folders to keep temp directories clean.
Bug Fixes
discoverSkills()anddiscoverAllSkills(), at lowest priority with de-duplication.getAgentsSkillDirsto resolve TS2305/TS7006 errors and correctly load.agents/skillsdirs.New Features
.gitignorein each team-mode worktree with common ignores.Written for commit 78d74f8. Summary will update on new commits.