Skip to content

fix: allow opted-in non-GPT Hephaestus registration#5402

Open
dyyxxhh wants to merge 1 commit into
code-yeongyu:devfrom
dyyxxhh:fix/hephaestus-allow-non-gpt-registration
Open

fix: allow opted-in non-GPT Hephaestus registration#5402
dyyxxhh wants to merge 1 commit into
code-yeongyu:devfrom
dyyxxhh:fix/hephaestus-allow-non-gpt-registration

Conversation

@dyyxxhh

@dyyxxhh dyyxxhh commented Jun 18, 2026

Copy link
Copy Markdown

Summary

  • Lets agents.hephaestus.allow_non_gpt_model: true bypass Hephaestus registration-time model checks.
  • Passes the opt-in through to Hephaestus prompt construction, where unsupported models use the generic GPT prompt instead of throwing.
  • Keeps the default behavior unchanged: without the explicit opt-in, non-GPT Hephaestus models are still skipped/rejected.

Test Plan

  • npx --yes bun@1.3.14 test packages/omo-opencode/src/agents/hephaestus/agent.test.ts
  • npx --yes bun@1.3.14 run typecheck:packages

Related question: #5399


Summary by cubic

Allow Hephaestus to register with non-GPT models when opted in via agents.hephaestus.allow_non_gpt_model: true, falling back to the generic GPT prompt instead of rejecting. Default behavior stays the same; without the flag, unsupported models are skipped.

  • Bug Fixes
    • Gate model support checks behind the opt-in during registration.
    • Plumb allowUnsupportedModel to prompt construction; use GPT prompt for unsupported models.
    • Add test to verify non-GPT registration with the flag and preserve apply_patch permission.

Written for commit 954afda. Summary will update on new commits.

Review in cubic

@EvangelosMoschou

Copy link
Copy Markdown
Contributor

Confirmed the approach matches what I was implementing locally. The fallback to the generic GPT prompt in agent.ts is clean, and the AgentOverrides type correctly exposes allow_non_gpt_model for hephaestus — no type cast needed. Thanks for taking this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

opencode OpenCode edition: packages/omo-opencode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants