Skip to content

fix: improve error propagation in SessionHttpApi to prevent opaque UnknownError during local model calls #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linzhanyu wants to merge 2 commits into
base: dev
Choose a base branch
from
+20 −12
Open

fix: improve error propagation in SessionHttpApi to prevent opaque UnknownError during local model calls #5551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968fb26
feat(agents): add buildGenericSisyphusAgentConfig for unknown models
linzhanyu Jun 21, 2026
2afc1c2
fix(agents): use generic fallback for unrecognized models in sisyphus…
linzhanyu Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/omo-opencode/src/agents/sisyphus-agent-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,15 @@ export function buildClaudeSisyphusAgentConfig(
...buildClaudeThinkingConfig(model),
};
}

/**
* Generic fallback config for high-performance instruction-following models
* (e.g., Gemma4, Qwen3.6 via llama.cpp) that don't match specific vendor patterns.
*/
export function buildGenericSisyphusAgentConfig(
mode: AgentMode,
model: string,
prompt: string,
): AgentConfig {
return buildBaseSisyphusAgentConfig(mode, model, prompt);
}
20 changes: 8 additions & 12 deletions packages/omo-opencode/src/agents/sisyphus-agent-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
buildClaudeSisyphusAgentConfig,
buildGlmSisyphusAgentConfig,
buildGptSisyphusAgentConfig,
buildGenericSisyphusAgentConfig,
} from "./sisyphus-agent-config";
import { buildFallbackSisyphusPrompt } from "./sisyphus-dynamic-prompt";
import { buildClaudeFable5SisyphusPrompt } from "./sisyphus/claude-fable-5";
Expand All @@ -26,7 +27,6 @@ import {
isClaudeOpus48Model,
isGlmModel,
isGpt5_5Model,
isGptModel,
isGptNativeSisyphusModel,
isKimiK2Model,
isKimiK27Model,
Expand Down Expand Up @@ -126,19 +126,15 @@ export function createSisyphusAgent(
model,
buildGlm52SisyphusPrompt(model, agents, tools, skills, categories, useTaskSystem),
);
case "fallback": {
const prompt = buildFallbackSisyphusPrompt(
case "fallback":
// For all unrecognized models (e.g., local llama.cpp via Gemma4/Qwen),
// use generic config instead of forcing GPT/Claude-specific behavior.
return buildGenericSisyphusAgentConfig(
MODE,
model,
agents,
tools,
skills,
categories,
useTaskSystem,
buildFallbackSisyphusPrompt(model, agents, tools, skills, categories, useTaskSystem),
);
return isGptModel(model)
? buildGptSisyphusAgentConfig(MODE, model, prompt)
: buildClaudeSisyphusAgentConfig(MODE, model, prompt);
}
}
}

createSisyphusAgent.mode = MODE;