[pull] master from supabase:master#833
Merged
Merged
Conversation
## Summary Reorder AddPaymentMethodForm and PaymentMethodSelection to use a dry run validation → Stripe payment setup → real update flow: - Validate address and tax ID via `dry_run: true` before touching Stripe - Proceed with Stripe payment method creation / 3DS only if validation passes - Persist the customer profile update with dry run disabled after Stripe succeeds - Add `dry_run` support to `useOrganizationCustomerProfileUpdateMutation` - Add `getFormValues()` to `PaymentMethodElementRef` to read address and tax ID form state - Delete the now-unused `organization-tax-id-update-mutation.ts` ## Test plan ### Adding a Payment Method From the billing dashboard `/org/_/billing`: - [ ] Add a payment method with a valid tax ID: should dry-run validate, then create the payment method via Stripe, then persist the billing profile - [ ] Add a payment method with an invalid tax ID: should show a validation error from the dry run and not proceed to Stripe payment setup - [ ] Add a payment method with the "primary billing address" checkbox unchecked: should skip the customer profile update entirely and only create the payment method - [ ] Add a payment method where Stripe 3DS fails: billing profile should not be persisted (only the dry run ran) ### Credit Top Up - [ ] Top up credits with a new payment method and valid tax ID: should dry-run validate, then create the payment method, then process the top-up - [ ] Top up credits with a new payment method and invalid tax ID: should show a validation error from the dry run and not proceed to Stripe payment method creation ### Plan Upgrade - [ ] Upgrade plan with a new payment method and valid tax ID: should dry-run validate before creating the payment method - [ ] Upgrade plan with a new payment method and invalid tax ID: should show a validation error and not proceed to Stripe - [ ] Upgrade plan with an existing payment method: should proceed without dry-run validation
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Blog post title update ## What is the current behavior? Blog post titled "Stripe Sync Engine: from supabase to stripe" at /blog/stripe-sync-engine-donation. ## What is the new behavior? - Title updated to "We're transferring the Stripe Sync Engine to Stripe" - Description updated to match new framing - Slug changed to stripe-sync-engine-transfer (/blog/stripe-sync-engine-transfer) - Image directory renamed to match new slug ## Additional context N/A <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Published a blog post announcing the transfer of the Stripe Sync Engine repository to its upstream maintainer, with full metadata and narrative covering timeline, continuity guarantees, licensing (Apache 2.0), redirects, and continued one‑click dashboard support. It lists new capabilities (coupons sync, branching support, immediate sync on install, one‑click upgrades, SSL enforcement, restricted admin controls, improved install UX, clearer errors, and dashboard visibility of function source). * Updated the public blog RSS feed to include the new post and recent entries. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Ana <ana1337x@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )