fix: Add default colors to Referendum results - #165
Open
danmana wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it fix?
Closes code4romania/rezultate-vot-client#109
The backend was returning the default
#808080gray color for referendum results.Added default colors to Referendum type results.
The colors used are the ones that are currently displayed in the
ElectionResultsStackedBar(which uses pseudo-random colors#6540bf#40bf9b#97bf40) - see live pageAlso updated a bit the docs to include info about how to install and run locally.
How has it been tested?
Not tested yet because I don't have a database dump to use on localhost.