ci: use pull_request trigger instead of push trigger
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surt91
changed the title
pull_request trigger instead of push trigger
christopherschaedlich
approved these changes
Jun 30, 2025
surt91
force-pushed
the
ci/use-ppull-request-trigger-instead-of-push
branch
from
e081e52 to
09d06f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario:
Commit 1 changes logic in the backend. It starts the backend tests, which fail.
Commit 2 changes a typo in the main readme. Since the push does not contain changes to the backend folder, no tests are started.
The pull request only shows the checks triggered by the last commit, which are all successful. The unsuccessful tests of previous commits are ignored.
So, in this scenario we could merge despite of failing tests.
To fix this, we change the trigger from
pushtopull_request, which will always trigger all jobs which are affected by the whole PR, everytime the PR changes (e.g. by a push to the corresponding branch).