Skip to content

Conversation

belfhi
Copy link
Contributor

@belfhi belfhi commented Apr 22, 2025

fixes #825

@belfhi belfhi requested a review from a team as a code owner April 22, 2025 12:40
@belfhi belfhi force-pushed the add-servicemonitor-tlsconfig branch from 4598ef1 to b4bfe83 Compare May 12, 2025 09:23
Copy link

This pull request has been marked as stale because it has been open for 30 days with no activity. It will be automatically closed in 10 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jul 11, 2025
@belfhi
Copy link
Contributor Author

belfhi commented Jul 14, 2025

could I get a commend on this PR? I think it's quite a useful feature, I had to disable the ServiceMonitor from the Chart and create my own since this setting was not possible. :)

@github-actions github-actions bot removed the Stale label Jul 14, 2025
@stefangries
Copy link
Collaborator

Hi @belfhi, Thank you for your contribution. I can merge it. Can you please first add this feature to the readme, as well?

@belfhi
Copy link
Contributor Author

belfhi commented Aug 11, 2025

I added a new field to the README @stefangries , is that what you mean? Or do you think a more detailed example would be helpful? I think keycloak using self-signed tls in the backend and "real" Certificates in the ingress controller is quite a common setup.

@stefangries
Copy link
Collaborator

Thats fine. Can you please fix the merge conflict as well? Thanks!

@belfhi belfhi force-pushed the add-servicemonitor-tlsconfig branch from bc43fde to 21d0358 Compare August 11, 2025 11:22
@belfhi
Copy link
Contributor Author

belfhi commented Aug 11, 2025

yes, sorry I rebased my branch and force pushed 👍

@stefangries
Copy link
Collaborator

Thanks!

@stefangries stefangries merged commit 7e6930a into codecentric:master Aug 11, 2025
3 checks passed
@sahil-sharma
Copy link

I think tlsConfig is not being released on 7.1.1 version. Correct me if I am wrong?
As I can't see it in its YAML.

@stefangries
Copy link
Collaborator

It will be released in the next version in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[keycloakx] servicemonitor tlsConfig

3 participants