-
Notifications
You must be signed in to change notification settings - Fork 619
[keycloakX] add tlsConfig to serviceMonitor #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keycloakX] add tlsConfig to serviceMonitor #827
Conversation
4598ef1
to
b4bfe83
Compare
This pull request has been marked as stale because it has been open for 30 days with no activity. It will be automatically closed in 10 days if no further activity occurs. |
could I get a commend on this PR? I think it's quite a useful feature, I had to disable the ServiceMonitor from the Chart and create my own since this setting was not possible. :) |
Hi @belfhi, Thank you for your contribution. I can merge it. Can you please first add this feature to the readme, as well? |
I added a new field to the README @stefangries , is that what you mean? Or do you think a more detailed example would be helpful? I think keycloak using self-signed tls in the backend and "real" Certificates in the ingress controller is quite a common setup. |
Thats fine. Can you please fix the merge conflict as well? Thanks! |
Signed-off-by: Johannes Reppin <[email protected]>
Signed-off-by: Johannes Reppin <[email protected]>
bc43fde
to
21d0358
Compare
yes, sorry I rebased my branch and force pushed 👍 |
Thanks! |
I think |
It will be released in the next version in a few days. |
fixes #825