[keycloakx] change ServiceAccount RBAC to Role & ClusterRole #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belfhi
force-pushed
the
remove-serviceaccount-cluster-permissions
branch
from
7e94637 to
1b73715
Compare
belfhi
changed the title
|
This pull request has been marked as stale because it has been open for 30 days with no activity. It will be automatically closed in 10 days if no further activity occurs. |
belfhi
force-pushed
the
remove-serviceaccount-cluster-permissions
branch
from
1b73715 to
f6b6746
Compare
Signed-off-by: Johannes Reppin <[email protected]>
belfhi
force-pushed
the
remove-serviceaccount-cluster-permissions
branch
from
f6b6746 to
e2edf40
Compare
|
@belfhi Do you think we should mark this as a breaking change? I'm currently thinking about various scenarios for the update and the effects of this change on existing installations. |
|
This pull request has been marked as stale because it has been open for 30 days with no activity. It will be automatically closed in 10 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClusterRole and ClusterRoleBinding is not needed, use Role and RoleBinding instead, fixes #829