feat: add separate labels to console ingress

[andrewjkeith]

add separate labels to console ingress

[stefangries]

Doesn't that have to be added to values.schema.json as well?

[andrewjkeith]

Doesn't that have to be added to values.schema.json as well?

it looks like there is a bunch of stuff missing from the values.schema.json file, should i run helm-schema against the vaules file to add it all or just the stuff in my MR?

[stefangries]

Thank you, I wasn't aware of that. It would be nice to have all the missing stuff added. Maybe in a separate pull request.

[jseiser]

@andrewjkeith Any update on getting the values updated on this one?

[andrewjkeith]

@stefangries i went ahead at refactored the values.schema.json, turns out it had several errors in there. let me know if you want a separate pull request

[stefangries]

Yes, please do separate pull requests for the refactoring and for this issue.

[andrewjkeith]

@stefangries ok i just opened a new PR here, thanks: #858

[stefangries]

Thank you. If I'm not mistaken, the changes to values.schema.json are currently in both this pull request #841 and the other one #858. Could you please remove them from this pull request so that they are not in both?

Please excuse the late reply.

[andrewjkeith]

@stefangries schema values from this PR have been removed