feat(cache-chart): Show hits/misses per poll interval #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikpetzold
approved these changes
Mar 26, 2025
erikpetzold
reviewed
Mar 26, 2025
| const lastChartData = this.chartData[this.chartData.length - 1]; | ||
| hitsPerInterval = data.hit - lastChartData.hit; | ||
| missesPerInterval = data.miss - lastChartData.miss; | ||
| totalPerInterval = data.total - lastChartData.total; |
There was a problem hiding this comment.
I think "previous" would be better than "last" (even if it is the "last" one in the array, we want the one that was before the current one, which is "previous")
There was a problem hiding this comment.
And I would prefer to have the calculation in a separate function (with tests :D ). But I understand that this may be awkward because we want to return three values and the calculation itself is really simple
hzpz
force-pushed
the
cache-chart-hits-misses-per-poll-interval
branch
from
9f6a517 to
81dfb71
Compare
hzpz
force-pushed
the
cache-chart-hits-misses-per-poll-interval
branch
from
81dfb71 to
fe31a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.