Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieving repoid through commit report can yield error #1132

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Feb 5, 2025

fixes: https://github.com/codecov/internal-issues/issues/1208
fixes: https://github.com/codecov/internal-issues/issues/1209

Sometimes having trouble getting the repo_id via upload.report path, showing a Commit Report does not exist error. Maybe some race condition where the commit report object is not committed to the DB yet. This change will just get the repo_id directly from the Repository object.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

sentry-io bot commented Feb 5, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: upload/serializers.py

Function Unhandled Issue
create CommitReport.DoesNotExist: CommitReport matching query does not exist. /upload/{service}/...
Event Count: 615
create Commit.DoesNotExist: Commit matching query does not exist. /upload/{service}/{repo}/uploa...
Event Count: 11

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (a12b039) to head (ad264ab).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1132   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         838      838           
  Lines       19775    19775           
=======================================
  Hits        18998    18998           
  Misses        777      777           
Flag Coverage Δ
unit 95.96% <100.00%> (ø)
unit-latest-uploader 95.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (a12b039) to head (ad264ab).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@JerrySentry JerrySentry marked this pull request as ready for review February 5, 2025 15:42
@JerrySentry JerrySentry requested a review from a team as a code owner February 5, 2025 15:42
@JerrySentry JerrySentry added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit d23a6a0 Feb 13, 2025
19 checks passed
@JerrySentry JerrySentry deleted the feb_05_fix_upload_serializer branch February 13, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants