Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move timeseries ORM related code to shared #1135

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

joseph-sentry
Copy link
Contributor

I want to move the models to shared because I want to be able to use the Django models in the worker.

Follow-up to codecov/shared#500

@joseph-sentry joseph-sentry requested a review from a team as a code owner February 5, 2025 21:14
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This PR includes changes to shared. Please review them here: codecov/shared@7ba099f...838bba5

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (ca253c1) to head (040c20f).
Report is 3 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
- Coverage   96.07%   96.05%   -0.02%     
==========================================
  Files         837      837              
  Lines       19856    19902      +46     
==========================================
+ Hits        19076    19117      +41     
- Misses        780      785       +5     
Flag Coverage Δ
unit 95.91% <100.00%> (-0.06%) ⬇️
unit-latest-uploader 95.91% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (ca253c1) to head (040c20f).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@joseph-sentry joseph-sentry requested a review from a team February 6, 2025 14:32
I want to move the models to shared because I want to be able to use
the Django models in the worker.
Copy link
Contributor

@michelletran-codecov michelletran-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would also suggest testing this on staging.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

This PR includes changes to shared. Please review them here: codecov/shared@7ba099f...9235672

@joseph-sentry joseph-sentry added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit b27a23b Feb 7, 2025
18 of 19 checks passed
@joseph-sentry joseph-sentry deleted the joseph/timeseries branch February 7, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants