fix: a couple of rest api unhandled errors #1139
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 837 837
Lines 19766 19771 +5
=======================================
+ Hits 18981 18986 +5
Misses 785 785
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
|
@codecov-ai-reviewer review |
|
On it! We are reviewing the PR and will provide feedback shortly. |
|
No changes requiring review at this time. |
| file = comparison.get_file_comparison(filename, bypass_max_diff=True) | ||
| if self._should_include_file(file): | ||
| data.append(FileComparisonSerializer(file).data) | ||
| if comparison.head_report is not None: |
There was a problem hiding this comment.
wondering if we should raise a validation indicating no head report for comparison?
There was a problem hiding this comment.
In the event it falls out of the if I mean
fixes: https://github.com/codecov/internal-issues/issues/1218
fixes: https://github.com/codecov/internal-issues/issues/1219
Catch some unhandled errors from REST API endpoints:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.