Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop double-counting unhandled_event in github webhook handler #1140

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Feb 6, 2025

it's handled here

if handler := getattr(self, self.event, None):
self._inc_recv()
return handler(request, *args, **kwargs)
else:
self._inc_err("unhandled_event")
return self.unhandled_webhook_event(request, *args, **kwargs)

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

sentry-io bot commented Feb 6, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: webhook_handlers/views/github.py

Function Unhandled Issue
validate_signature TypeError: '>' not supported between instances of 'int' and 'str' /webhooks/...
Event Count: 84

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (ca253c1) to head (6bd89e8).
Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
- Coverage   96.07%   96.07%   -0.01%     
==========================================
  Files         837      837              
  Lines       19856    19855       -1     
==========================================
- Hits        19076    19075       -1     
  Misses        780      780              
Flag Coverage Δ
unit 95.97% <ø> (-0.01%) ⬇️
unit-latest-uploader 95.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (ca253c1) to head (6bd89e8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@matt-codecov matt-codecov added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 7bd85ae Feb 6, 2025
18 of 19 checks passed
@matt-codecov matt-codecov deleted the matt/remove-unhandled-webhook-doublecount branch February 6, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants