Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fetch latest upload error for a commit #1151

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
We need to reflect the latest upload error for a given commit, this is needed to reflect test analytic uploads branch specific errors

Links to relevant tickets

Closes #3344

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled requested a review from a team as a code owner February 11, 2025 11:08
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (8174946) to head (ea4214b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1151   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         837      838    +1     
  Lines       19777    19806   +29     
=======================================
+ Hits        18994    19023   +29     
  Misses        783      783           
Flag Coverage Δ
unit 95.93% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (8174946) to head (ea4214b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@RulaKhaled RulaKhaled enabled auto-merge February 11, 2025 14:57
@RulaKhaled RulaKhaled added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 659b4ec Feb 11, 2025
18 of 19 checks passed
@RulaKhaled RulaKhaled deleted the fetch-latest-error branch February 11, 2025 15:23
Copy link

sentry-io bot commented Feb 19, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ DatabaseError: (sqlite3.DatabaseError) file is not a database /graphql/{service} View Issue
  • ‼️ GraphQLError: (sqlite3.DatabaseError) file is not a database /graphql/{service} View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Reflect the latest upload error for a commit
2 participants