Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django admin impersonation styling part II #1234

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

nora-codecov
Copy link
Contributor

Links to relevant tickets

codecov/engineering-team#3465

What does this PR do?

My previous approach to alter the header was being rejected by our CSP. This method changes the text rather than showing/hiding things which should be allowed.

@nora-codecov nora-codecov requested review from ajay-sentry and a team March 21, 2025 23:55
Copy link
Contributor

✅ Sentry found no issues in your recent changes ✅

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (6e6d2be) to head (16b62a7).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files         492      492           
  Lines       16805    16805           
=======================================
  Hits        16185    16185           
  Misses        620      620           
Flag Coverage Δ
unit 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant