Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make label-analysis and static-analysis noops #663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Mar 17, 2025

This rips out all of static-analysis including building treesitter languages and processing source files.

Ripping out label-analysis works rather by running the fallback code unconditionally without making requests to the backend API.


I would still wait with this a little until we have the final go-ahead in codecov/engineering-team#3364

Copy link

github-actions bot commented Mar 17, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Swatinem Swatinem force-pushed the swatinem/noop-ats branch from ae29c1f to 73515a1 Compare March 17, 2025 14:59
Copy link

codecov bot commented Mar 17, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3420 5 3415 0
View the top 3 failed test(s) by shortest run time
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Base automatically changed from swatinem/hide-ats to main March 18, 2025 08:05
@Swatinem Swatinem force-pushed the swatinem/noop-ats branch from 73515a1 to 15d537d Compare March 18, 2025 09:02
@Swatinem Swatinem marked this pull request as ready for review March 18, 2025 09:02
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to split the build changes from the noop changes in a different PR. We've had issues with our build system already recently and I'd like to ensure that these changes will still produce the correct assets.

This rips out all of `static-analysis`, but keeps the treesitter `languages` and associated build infrastructure for now.

Ripping out `label-analysis` works rather by running the fallback code unconditionally without making requests to the backend API.
@Swatinem Swatinem force-pushed the swatinem/noop-ats branch from 63b952e to 30086d4 Compare March 20, 2025 09:27
@Swatinem
Copy link
Contributor Author

I split out the build system related changes to #664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants