-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make label-analysis
and static-analysis
noops
#663
base: main
Are you sure you want to change the base?
Conversation
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
ae29c1f
to
73515a1
Compare
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
73515a1
to
15d537d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to split the build changes from the noop changes in a different PR. We've had issues with our build system already recently and I'd like to ensure that these changes will still produce the correct assets.
15d537d
to
63b952e
Compare
This rips out all of `static-analysis`, but keeps the treesitter `languages` and associated build infrastructure for now. Ripping out `label-analysis` works rather by running the fallback code unconditionally without making requests to the backend API.
63b952e
to
30086d4
Compare
I split out the build system related changes to #664 |
This rips out all of
static-analysis
including building treesitter languages and processing source files.Ripping out
label-analysis
works rather by running the fallback code unconditionally without making requests to the backend API.I would still wait with this a little until we have the final go-ahead in codecov/engineering-team#3364