Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove minification of packages #248

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

nicholas-codecov
Copy link
Collaborator

@nicholas-codecov nicholas-codecov commented Feb 10, 2025

Description

This PR removes one build setting for all of the plugins: minification. We're removing minification because as these are dev deps, and are fairly small there's really no reason to minify the packages and make things harder to read/debug if any errors are raised.

Note, reverted changes for sourcemaps, as we're still bundling into a single file, where the sourcemap will point us to the file where the code lives.

Notable Changes

  • Stop output packages from being minified

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 98.05% <ø> (ø)
Rollup plugin 8.42% <ø> (ø)
Vite plugin 8.42% <ø> (ø)
Webpack plugin 56.84% <ø> (ø)

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (043b250) to head (8e99d8b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 98.05% <ø> (ø)
Rollup plugin 8.42% <ø> (ø)
Vite plugin 8.42% <ø> (ø)
Webpack plugin 56.84% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Feb 10, 2025

Bundle Report

Changes will increase total bundle size by 199.38kB (3.1%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/vite-plugin-cjs 6.74kB 3.51kB (108.67%) ⬆️
@codecov/remix-vite-plugin-cjs 3.09kB 1.41kB (84.13%) ⬆️
@codecov/remix-vite-plugin-esm 957 bytes -502 bytes (-34.41%) ⬇️
@codecov/bundler-plugin-core-cjs 313.66kB 175.65kB (127.26%) ⬆️
@codecov/rollup-plugin-cjs 6.77kB 3.52kB (107.99%) ⬆️
@codecov/nuxt-plugin-cjs 3.24kB 1.47kB (83.24%) ⬆️
@codecov/sveltekit-plugin-cjs 3.1kB 1.38kB (80.58%) ⬆️
@codecov/webpack-plugin-cjs 9.62kB 4.67kB (94.15%) ⬆️
@codecov/solidstart-plugin-cjs 3.11kB 1.38kB (80.37%) ⬆️
@codecov/example-sveltekit-app-client-esm 727.49kB 2 bytes (0.0%) ⬆️
@codecov/example-sveltekit-app-server-esm 984.45kB 1 bytes (0.0%) ⬆️
@codecov/nextjs-webpack-plugin-cjs 4.94kB 2.3kB (87.09%) ⬆️
@codecov/bundle-analyzer-cjs 7.78kB 3.4kB (77.43%) ⬆️
@codecov/bundle-analyzer-esm 3.11kB -399 bytes (-11.38%) ⬇️
@codecov/astro-plugin-cjs 3.31kB 1.6kB (93.57%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @codecov/webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 3.45kB 3.45kB 100.0% 🚀
index.d.cts (Deleted) -3.45kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/solidstart-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.38kB 3.11kB 80.37% ⚠️
view changes for bundle: @codecov/astro-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.6kB 3.31kB 93.57% ⚠️
view changes for bundle: @codecov/example-sveltekit-app-client-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_app/immutable/chunks/entry.*.js 2 bytes 31.46kB 0.01%
view changes for bundle: @codecov/nextjs-webpack-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 2.3kB 4.94kB 87.09% ⚠️
view changes for bundle: @codecov/vite-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 3.51kB 6.74kB 108.67% ⚠️
view changes for bundle: @codecov/bundler-plugin-core-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 175.65kB 313.66kB 127.26% ⚠️
view changes for bundle: @codecov/rollup-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 3.52kB 6.77kB 107.99% ⚠️
view changes for bundle: @codecov/example-next-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
server/middleware-*.js -852 bytes 36 bytes -95.95%
server/middleware-*.js 852 bytes 888 bytes 2366.67% ⚠️
static/wOOnZjk6nMragjly0tI46/_buildManifest.js (New) 224 bytes 224 bytes 100.0% 🚀
static/wOOnZjk6nMragjly0tI46/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Uey26EsK4RBOQuyfTF3k9/_buildManifest.js (Deleted) -224 bytes 0 bytes -100.0% 🗑️
static/Uey26EsK4RBOQuyfTF3k9/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/nextjs-webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 1.11kB 1.11kB 100.0% 🚀
index.d.mts (Deleted) -1.11kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundle-analyzer-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 2.3kB 4.37kB 111.47% ⚠️
cli.cjs 1.09kB 3.41kB 47.11% ⚠️
view changes for bundle: @codecov/astro-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.cts (New) 862 bytes 862 bytes 100.0% 🚀
index.d.ts (Deleted) -862 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/nuxt-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 855 bytes 855 bytes 100.0% 🚀
index.d.mts (Deleted) -855 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/webpack-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 4.67kB 9.62kB 94.15% ⚠️
view changes for bundle: @codecov/nuxt-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.47kB 3.24kB 83.24% ⚠️
view changes for bundle: @codecov/bundle-analyzer-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 2.77kB 2.77kB 100.0% 🚀
cli.d.ts (New) 342 bytes 342 bytes 100.0% 🚀
cli.mjs (Deleted) -1.99kB 0 bytes -100.0% 🗑️
index.mjs (Deleted) -1.52kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/solidstart-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 949 bytes 949 bytes 100.0% 🚀
index.d.mts (Deleted) -949 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-sveltekit-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/internal.js 1 bytes 18.48kB 0.01%
view changes for bundle: @codecov/example-next-15-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/MLL69PJwvvXwkMmbaP7te/_buildManifest.js (New) 540 bytes 540 bytes 100.0% 🚀
static/MLL69PJwvvXwkMmbaP7te/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/cfN02eKskjf1PWGH_CUeJ/_buildManifest.js (Deleted) -540 bytes 0 bytes -100.0% 🗑️
static/cfN02eKskjf1PWGH_CUeJ/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundler-plugin-core-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 14.67kB 14.67kB 100.0% 🚀
index.d.ts (Deleted) -14.67kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/remix-vite-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 957 bytes 957 bytes 100.0% 🚀
index.mjs (Deleted) -1.46kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/remix-vite-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.41kB 3.09kB 84.13% ⚠️
view changes for bundle: @codecov/sveltekit-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.38kB 3.1kB 80.58% ⚠️

@codecov-staging
Copy link

codecov-staging bot commented Feb 10, 2025

Bundle Report

Changes will increase total bundle size by 201.35kB (3.21%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/bundler-plugin-core-cjs 313.66kB 175.65kB (127.26%) ⬆️
@codecov/vite-plugin-cjs 6.74kB 3.51kB (108.67%) ⬆️
@codecov/bundle-analyzer-esm 3.11kB -399 bytes (-11.38%) ⬇️
@codecov/webpack-plugin-cjs 9.62kB 4.59kB (91.22%) ⬆️
@codecov/bundle-analyzer-cjs 7.78kB 3.4kB (77.43%) ⬆️
@codecov/solidstart-plugin-cjs 3.11kB 1.38kB (80.37%) ⬆️
@codecov/sveltekit-plugin-cjs 3.1kB 1.38kB (80.58%) ⬆️
@codecov/solidstart-plugin-esm 3.03kB 2.08kB (219.7%) ⬆️
@codecov/nuxt-plugin-cjs 3.24kB 1.47kB (83.24%) ⬆️
@codecov/nextjs-webpack-plugin-cjs 4.94kB 2.3kB (87.09%) ⬆️
@codecov/webpack-plugin-esm 3.45kB -511 bytes (-12.9%) ⬇️
@codecov/rollup-plugin-cjs 6.77kB 3.52kB (107.99%) ⬆️
@codecov/remix-vite-plugin-cjs 3.09kB 1.38kB (81.1%) ⬆️
@codecov/astro-plugin-cjs 3.31kB 1.6kB (93.57%) ⬆️
@codecov/example-sveltekit-app-client-esm 727.49kB 2 bytes (0.0%) ⬆️
@codecov/example-sveltekit-app-server-esm 984.45kB 1 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @codecov/example-sveltekit-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/internal.js 1 bytes 18.48kB 0.01%
view changes for bundle: @codecov/sveltekit-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.38kB 3.1kB 80.58% ⚠️
view changes for bundle: @codecov/remix-vite-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 957 bytes 957 bytes 100.0% 🚀
index.d.ts (Deleted) -957 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundler-plugin-core-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 175.65kB 313.66kB 127.26% ⚠️
view changes for bundle: @codecov/bundle-analyzer-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 2.3kB 4.37kB 111.47% ⚠️
cli.cjs 1.09kB 3.41kB 47.11% ⚠️
view changes for bundle: @codecov/nextjs-webpack-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 2.3kB 4.94kB 87.09% ⚠️
view changes for bundle: @codecov/webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.cts (New) 3.45kB 3.45kB 100.0% 🚀
index.mjs (Deleted) -3.96kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/remix-vite-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.38kB 3.09kB 81.1% ⚠️
view changes for bundle: @codecov/solidstart-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.38kB 3.11kB 80.37% ⚠️
view changes for bundle: @codecov/bundle-analyzer-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 2.77kB 2.77kB 100.0% 🚀
cli.d.ts (New) 342 bytes 342 bytes 100.0% 🚀
cli.mjs (Deleted) -1.99kB 0 bytes -100.0% 🗑️
index.mjs (Deleted) -1.52kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/vite-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 3.51kB 6.74kB 108.67% ⚠️
view changes for bundle: @codecov/rollup-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 1.3kB 1.3kB 100.0% 🚀
index.d.cts (Deleted) -1.3kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/rollup-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 3.52kB 6.77kB 107.99% ⚠️
view changes for bundle: @codecov/astro-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 862 bytes 862 bytes 100.0% 🚀
index.d.mts (Deleted) -862 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundler-plugin-core-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 14.67kB 14.67kB 100.0% 🚀
index.d.mts (Deleted) -14.67kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/astro-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.6kB 3.31kB 93.57% ⚠️
view changes for bundle: @codecov/example-next-15-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
server/middleware-*.js 873 bytes 909 bytes 2425.0% ⚠️
server/middleware-*.js -873 bytes 36 bytes -96.04%
static/3R7zWJEYWDSdvQTHcqDri/_buildManifest.js (New) 540 bytes 540 bytes 100.0% 🚀
static/3R7zWJEYWDSdvQTHcqDri/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/1HSJn_dLylwDl6bvhHuAo/_buildManifest.js (Deleted) -540 bytes 0 bytes -100.0% 🗑️
static/1HSJn_dLylwDl6bvhHuAo/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-next-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
server/middleware-*.js -852 bytes 36 bytes -95.95%
server/middleware-*.js 852 bytes 888 bytes 2366.67% ⚠️
static/UWhDUPji3tz98sgjTwaL-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/UWhDUPji3tz98sgjTwaL-*.js (New) 224 bytes 224 bytes 100.0% 🚀
static/JqQvHsXsfWV-*.js (Deleted) -224 bytes 0 bytes -100.0% 🗑️
static/JqQvHsXsfWV-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/webpack-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 4.59kB 9.62kB 91.22% ⚠️
view changes for bundle: @codecov/solidstart-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 3.03kB 3.03kB 100.0% 🚀
index.d.mts (Deleted) -949 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/nuxt-plugin-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.cjs 1.47kB 3.24kB 83.24% ⚠️
view changes for bundle: @codecov/example-sveltekit-app-client-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_app/immutable/chunks/entry.*.js 2 bytes 31.46kB 0.01%

@nicholas-codecov nicholas-codecov changed the title feat: Remove minification & sourcemaps of packages feat: Remove minification of packages Feb 10, 2025
@nicholas-codecov nicholas-codecov merged commit 06f90eb into main Feb 10, 2025
69 checks passed
@nicholas-codecov nicholas-codecov deleted the feat-remove-minification-of-packages branch February 10, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants