-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove minification of packages #248
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 199.38kB (3.1%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-cjsAssets Changed:
view changes for bundle: @codecov/astro-plugin-cjsAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-client-esmAssets Changed:
view changes for bundle: @codecov/nextjs-webpack-plugin-cjsAssets Changed:
view changes for bundle: @codecov/vite-plugin-cjsAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-cjsAssets Changed:
view changes for bundle: @codecov/rollup-plugin-cjsAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/nextjs-webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-cjsAssets Changed:
view changes for bundle: @codecov/astro-plugin-esmAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-esmAssets Changed:
view changes for bundle: @codecov/webpack-plugin-cjsAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-cjsAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-esmAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-server-esmAssets Changed:
view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-cjsAssets Changed:
view changes for bundle: @codecov/sveltekit-plugin-cjsAssets Changed:
|
Bundle ReportChanges will increase total bundle size by 201.35kB (3.21%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/example-sveltekit-app-server-esmAssets Changed:
view changes for bundle: @codecov/sveltekit-plugin-cjsAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-cjsAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-cjsAssets Changed:
view changes for bundle: @codecov/nextjs-webpack-plugin-cjsAssets Changed:
view changes for bundle: @codecov/webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-cjsAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-cjsAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-esmAssets Changed:
view changes for bundle: @codecov/vite-plugin-cjsAssets Changed:
view changes for bundle: @codecov/rollup-plugin-esmAssets Changed:
view changes for bundle: @codecov/rollup-plugin-cjsAssets Changed:
view changes for bundle: @codecov/astro-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-esmAssets Changed:
view changes for bundle: @codecov/astro-plugin-cjsAssets Changed:
view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/webpack-plugin-cjsAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-esmAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-cjsAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-client-esmAssets Changed:
|
Description
This PR removes one build setting for all of the plugins: minification. We're removing minification because as these are dev deps, and are fairly small there's really no reason to minify the packages and make things harder to read/debug if any errors are raised.
Note, reverted changes for sourcemaps, as we're still bundling into a single file, where the sourcemap will point us to the file where the code lives.
Notable Changes