SqliteReportBuilder: pull rng from test_utils instead of dependency injection #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't really like this approach so this is more of an RFC. now that it's written i'm kind of thinking about giving up on controlling the RNG to begin with though haha
currently
parse_pyreport()
takes an output file. i want to expose to Python a version that doesn't which will create a new db instd::env::temp_dir()
. sinceparse_pyreport()
andSqliteReportBuilder
already have multiple entrypoints to allow controlling the RNG, this is making things messierthe other approach is something like
but then to use the same approach with
SqliteReportBuilder
you need aSqliteReportBuilderBuilder
which is sillyStack created with Sapling. Best reviewed with ReviewStack.