feat: Add appless pre-PAT onboarding container (#3629)

New onboarding container and install codecov modal

src/App.test.tsx

@@ -84,7 +84,6 @@ const user = {
       student: false,
       studentCreatedAt: null,
       studentUpdatedAt: null,
-      customerIntent: 'PERSONAL',
     },
     trackingMetadata: {
       service: 'github',

src/App.tsx

@@ -20,6 +20,7 @@ import { ThemeContextProvider } from 'shared/ThemeContext'
 
 import AccountSettings from './pages/AccountSettings'
 import AdminSettings from './pages/AdminSettings'
+import { OnboardingContainerProvider } from './pages/OwnerPage/OnboardingContainerContext/context'
 const AnalyticsPage = lazy(() => import('./pages/AnalyticsPage'))
 const CodecovAIPage = lazy(() => import('./pages/CodecovAIPage'))
 const CommitDetailPage = lazy(() => import('./pages/CommitDetailPage'))
@@ -197,8 +198,10 @@ function App() {
     <>
       <ThemeContextProvider>
         <ToastNotificationProvider>
-          <ReactQueryDevtools initialIsOpen={false} />
-          <MainAppRoutes />
+          <OnboardingContainerProvider>
+            <ReactQueryDevtools initialIsOpen={false} />
+            <MainAppRoutes />
+          </OnboardingContainerProvider>
         </ToastNotificationProvider>
         <Toaster />
       </ThemeContextProvider>

src/layouts/BaseLayout/BaseLayout.test.tsx

@@ -27,13 +27,7 @@ const mockedUseImpersonate = useImpersonate as Mock
 vi.mock('shared/GlobalTopBanners', () => ({
   default: () => 'GlobalTopBanners',
 }))
-vi.mock('./InstallationHelpBanner', () => ({
-  default: () => 'InstallationHelpBanner',
-}))
 vi.mock('pages/TermsOfService', () => ({ default: () => 'TermsOfService' }))
-vi.mock('pages/DefaultOrgSelector', () => ({
-  default: () => 'DefaultOrgSelector',
-}))
 vi.mock('layouts/Header', () => ({ default: () => 'Header' }))
 vi.mock('layouts/Footer', () => ({ default: () => 'Footer' }))
 
@@ -53,7 +47,6 @@ const mockUser = {
   student: false,
   studentCreatedAt: null,
   studentUpdatedAt: null,
-  customerIntent: 'BUSINESS',
   externalId: 'asdf',
   owners: [
     {
@@ -330,9 +323,6 @@ describe('BaseLayout', () => {
         const hello = screen.getByText('hello')
         expect(hello).toBeInTheDocument()
 
-        const defaultOrg = screen.queryByText(/DefaultOrgSelector/)
-        expect(defaultOrg).not.toBeInTheDocument()
-
         const termsOfService = screen.queryByText(/TermsOfService/)
         expect(termsOfService).not.toBeInTheDocument()
       })
@@ -352,9 +342,6 @@ describe('BaseLayout', () => {
         const hello = screen.getByText('hello')
         expect(hello).toBeInTheDocument()
 
-        const defaultOrg = screen.queryByText(/DefaultOrgSelector/)
-        expect(defaultOrg).not.toBeInTheDocument()
-
         const termsOfService = screen.queryByText(/TermsOfService/)
         expect(termsOfService).not.toBeInTheDocument()
       })
@@ -385,68 +372,19 @@ describe('BaseLayout', () => {
         const header = screen.queryByText(/Header/)
         expect(header).not.toBeInTheDocument()
       })
-
-      it('renders help banner', async () => {
-        setup({
-          currentUser: userNoTermsAgreement,
-          internalUser: mockUserNoTermsAgreement,
-        })
-
-        render(<BaseLayout>hello</BaseLayout>, { wrapper: wrapper() })
-        const helpBanner = await screen.findByText(/InstallationHelpBanner/)
-        expect(helpBanner).toBeInTheDocument()
-      })
-    })
-
-    describe('when no default org selected', () => {
-      it('renders the default org selector', async () => {
-        setup({
-          currentUser: loggedInUser,
-          internalUser: mockUser,
-        })
-        render(<BaseLayout>hello</BaseLayout>, { wrapper: wrapper() })
-
-        const defaultOrgSelector = await screen.findByText(/DefaultOrgSelector/)
-        expect(defaultOrgSelector).toBeInTheDocument()
-      })
-
-      it('does not render the header', async () => {
-        setup({
-          currentUser: loggedInUser,
-          internalUser: mockUser,
-        })
-        render(<BaseLayout>hello</BaseLayout>, { wrapper: wrapper() })
-
-        const defaultOrgSelector = await screen.findByText(/DefaultOrgSelector/)
-        expect(defaultOrgSelector).toBeInTheDocument()
-
-        const header = screen.queryByText(/Header/)
-        expect(header).not.toBeInTheDocument()
-      })
-
-      it('renders help banner', async () => {
-        setup({
-          currentUser: loggedInUser,
-          internalUser: mockUser,
-        })
-
-        render(<BaseLayout>hello</BaseLayout>, { wrapper: wrapper() })
-        const helpBanner = await screen.findByText(/InstallationHelpBanner/)
-        expect(helpBanner).toBeInTheDocument()
-      })
     })
 
-    describe('when agreed to TOS and default org selected', () => {
+    describe('when agreed to TOS', () => {
       it('renders children', async () => {
-        setup({ currentUser: userHasDefaultOrg })
+        setup({ currentUser: loggedInUser })
         render(<BaseLayout>hello</BaseLayout>, { wrapper: wrapper() })
 
         const children = await screen.findByText(/hello/)
         expect(children).toBeInTheDocument()
       })
 
       it('renders header', async () => {
-        setup({ currentUser: userHasDefaultOrg })
+        setup({ currentUser: loggedInUser })
         render(<BaseLayout>hello</BaseLayout>, { wrapper: wrapper() })
 
         const header = await screen.findByText(/Header/)
@@ -488,9 +426,6 @@ describe('BaseLayout', () => {
         const hello = screen.getByText('hello')
         expect(hello).toBeInTheDocument()
 
-        const defaultOrg = screen.queryByText(/DefaultOrgSelector/)
-        expect(defaultOrg).not.toBeInTheDocument()
-
         const termsOfService = screen.queryByText(/TermsOfService/)
         expect(termsOfService).not.toBeInTheDocument()
       })
@@ -510,9 +445,6 @@ describe('BaseLayout', () => {
         const hello = screen.getByText('hello')
         expect(hello).toBeInTheDocument()
 
-        const defaultOrg = screen.queryByText(/DefaultOrgSelector/)
-        expect(defaultOrg).not.toBeInTheDocument()
-
         const termsOfService = screen.queryByText(/TermsOfService/)
         expect(termsOfService).not.toBeInTheDocument()
       })
@@ -550,23 +482,20 @@ describe('BaseLayout', () => {
 
         const header = await screen.findByText(/Header/)
         expect(header).toBeInTheDocument()
-
-        const defaultOrgSelector = screen.queryByText(/DefaultOrgSelector/)
-        expect(defaultOrgSelector).not.toBeInTheDocument()
       })
     })
 
     describe('when agreed to TOS and default org selected', () => {
       it('renders children', async () => {
-        setup({ currentUser: userHasDefaultOrg })
+        setup({ currentUser: loggedInUser })
         render(<BaseLayout>hello</BaseLayout>, { wrapper: wrapper() })
 
         const children = await screen.findByText(/hello/)
         expect(children).toBeInTheDocument()
       })
 
       it('renders header', async () => {
-        setup({ currentUser: userHasDefaultOrg })
+        setup({ currentUser: loggedInUser })
         render(<BaseLayout>hello</BaseLayout>, { wrapper: wrapper() })
 
         const header = await screen.findByText(/Header/)

src/layouts/BaseLayout/BaseLayout.tsx

@@ -20,8 +20,6 @@ import LoadingLogo from 'ui/LoadingLogo'
 import { NavigatorDataQueryOpts } from './hooks/NavigatorDataQueryOpts'
 import { useUserAccessGate } from './hooks/useUserAccessGate'
 
-const DefaultOrgSelector = lazy(() => import('pages/DefaultOrgSelector'))
-const InstallationHelpBanner = lazy(() => import('./InstallationHelpBanner'))
 const TermsOfService = lazy(() => import('pages/TermsOfService'))
 
 const FullPageLoader = () => (
@@ -31,20 +29,16 @@ const FullPageLoader = () => (
 )
 
 interface OnboardingOrChildrenProps extends React.PropsWithChildren {
-  isImpersonating: boolean
   isFullExperience: boolean
   showAgreeToTerms: boolean
   redirectToSyncPage: boolean
-  showDefaultOrgSelector: boolean
 }
 
 function OnboardingOrChildren({
   children,
-  isImpersonating,
   isFullExperience,
   showAgreeToTerms,
   redirectToSyncPage,
-  showDefaultOrgSelector,
 }: OnboardingOrChildrenProps) {
   if (showAgreeToTerms && !isFullExperience) {
     return (
@@ -58,14 +52,6 @@ function OnboardingOrChildren({
     return <Redirect to="/sync" />
   }
 
-  if (showDefaultOrgSelector && !isFullExperience && !isImpersonating) {
-    return (
-      <Suspense fallback={null}>
-        <DefaultOrgSelector />
-      </Suspense>
-    )
-  }
-
   return <>{children}</>
 }
 
@@ -83,7 +69,6 @@ function BaseLayout({ children }: React.PropsWithChildren) {
   const {
     isFullExperience,
     showAgreeToTerms,
-    showDefaultOrgSelector,
     redirectToSyncPage,
     isLoading: isUserAccessGateLoading,
   } = useUserAccessGate()
@@ -119,11 +104,7 @@ function BaseLayout({ children }: React.PropsWithChildren) {
                   <GlobalTopBanners />
                   <Header hasRepoAccess={data?.hasRepoAccess} />
                 </>
-              ) : (
-                <>
-                  {showDefaultOrgSelector ? <InstallationHelpBanner /> : null}
-                </>
-              )}
+              ) : null}
             </SilentNetworkErrorWrapper>
           </ErrorBoundary>
         </Suspense>
@@ -137,9 +118,7 @@ function BaseLayout({ children }: React.PropsWithChildren) {
                 <OnboardingOrChildren
                   isFullExperience={isFullExperience}
                   showAgreeToTerms={showAgreeToTerms}
-                  showDefaultOrgSelector={showDefaultOrgSelector}
                   redirectToSyncPage={redirectToSyncPage}
-                  isImpersonating={isImpersonating}
                 >
                   {children}
                 </OnboardingOrChildren>
@@ -149,12 +128,12 @@ function BaseLayout({ children }: React.PropsWithChildren) {
         </Suspense>
 
         {/* Footer */}
-        {isFullExperience && (
+        {isFullExperience ? (
           <>
             <Footer />
             <ToastNotifications />
           </>
-        )}
+        ) : null}
       </RepoBreadcrumbProvider>
     </>
   )