-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Default to All branches when default branch has no commits #2446
feat: Default to All branches when default branch has no commits #2446
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2446 +/- ##
=======================================
+ Coverage 98.07 98.08 +0.01
=======================================
Files 763 764 +1
Lines 9691 9724 +33
Branches 2397 2455 +58
=======================================
+ Hits 9504 9537 +33
Misses 185 185
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2446 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 763 764 +1
Lines 9691 9724 +33
Branches 2397 2436 +39
=======================================
+ Hits 9504 9537 +33
Misses 185 185
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2446 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 763 764 +1
Lines 9691 9724 +33
Branches 2441 2450 +9
=======================================
+ Hits 9504 9537 +33
Misses 185 185
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1d69c8d
to
1a54a56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git diff provides an overall decent implementation, but there are a few key areas that need improvement or clarification. The main issues include hard-coded string values for data comparison, the use of low-level hooks, potential over-fetching of data, and a lack of clear error handling.
…overage-on-default-branch-on-commits-page
Description
This PR makes it so that when you visit the commits tab of a repo whose default branch has no commits it will swap over to the
All branches
option by updating the query params on the initial render, so users can force their way back to the default branch if they wish to investigate further.Closes codecov/engineering-team#870
Notable Changes
useBranchHasCommits
hookCommitsTab
to swap toAll branches
when default branch has no commits only on initial render.Screenshots
Screen.Recording.2023-12-08.at.10.35.02.mov