feat: Default to All branches when default branch has no commits - Round 2 #2449

nicholas-codecov · 2023-12-11T19:55:45Z

Description

This PR makes it so that when you visit the commits tab of a repo whose default branch has no commits it will swap over to the All branches option by updating the query params on the initial render, so users can force their way back to the default branch if they wish to investigate further.

Closes codecov/engineering-team#870

Notable Changes

Add new useBranchHasCommits hook
Update CommitsTab to swap to All branches when default branch has no commits only on initial render.

Screenshots

Screen.Recording.2023-12-08.at.10.35.02.mov

…e view

…overage-on-default-branch-on-commits-page

codecov-public-qa · 2023-12-11T19:58:46Z

Codecov Report

Merging #2449 (fb7d6d5) into main (2dc6e67) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2449   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         766      767    +1     
  Lines        9753     9786   +33     
  Branches     2419     2430   +11     
=======================================
+ Hits         9567     9600   +33     
  Misses        184      184           
  Partials        2        2

Files	Coverage Δ
src/pages/RepoPage/CommitsTab/CommitsTab.jsx	`100.00% <100.00%> (ø)`
src/services/branches/useBranchHasCommits.tsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`97.30% <ø> (ø)`
Pages	`98.96% <100.00%> (+<0.01%)`	⬆️
Services	`99.44% <100.00%> (+<0.01%)`	⬆️
Shared	`99.81% <ø> (ø)`
UI	`94.32% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc6e67...fb7d6d5. Read the comment docs.

codecov-qa · 2023-12-11T19:58:48Z

Codecov Report

Merging #2449 (fb7d6d5) into main (2dc6e67) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2449   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         766      767    +1     
  Lines        9753     9786   +33     
  Branches     2465     2479   +14     
=======================================
+ Hits         9567     9600   +33     
  Misses        184      184           
  Partials        2        2

Files	Coverage Δ
src/pages/RepoPage/CommitsTab/CommitsTab.jsx	`100.00% <100.00%> (ø)`
src/services/branches/useBranchHasCommits.tsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`97.30% <ø> (ø)`
Pages	`98.96% <100.00%> (+<0.01%)`	⬆️
Services	`99.44% <100.00%> (+<0.01%)`	⬆️
Shared	`99.81% <ø> (ø)`
UI	`94.32% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc6e67...fb7d6d5. Read the comment docs.

codecov · 2023-12-11T19:59:00Z

Codecov Report

Merging #2449 (fb7d6d5) into main (2dc6e67) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #2449     +/-   ##
=======================================
+ Coverage   98.09   98.10   +0.01     
=======================================
  Files        766     767      +1     
  Lines       9753    9786     +33     
  Branches    2465    2479     +14     
=======================================
+ Hits        9567    9600     +33     
  Misses       184     184             
  Partials       2       2

Files	Coverage Δ
src/pages/RepoPage/CommitsTab/CommitsTab.jsx	`100.00% <100.00%> (ø)`
src/services/branches/useBranchHasCommits.tsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`97.30% <ø> (ø)`
Pages	`98.96% <100.00%> (+<0.01%)`	⬆️
Services	`99.44% <100.00%> (+<0.01%)`	⬆️
Shared	`99.81% <ø> (ø)`
UI	`94.32% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc6e67...fb7d6d5. Read the comment docs.

netlify · 2023-12-11T19:59:23Z

✅ Deploy Preview for gazebo-staging ready!

Name	Link
🔨 Latest commit	`fb7d6d5`
🔍 Latest deploy log	https://app.netlify.com/sites/gazebo-staging/deploys/65788d268a742b0008a07f52
😎 Deploy Preview	https://deploy-preview-2449--gazebo-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…overage-on-default-branch-on-commits-page

…und 2 (#2449) Default to `All branches` on commits page when default branch has no commits, attempt number 2. GH codecov/engineering-team#870

nicholas-codecov added 6 commits December 11, 2023 14:22

add new useBranchHasCommits hook

fcfb760

select all branches when default branch has no commits on initial pag…

1a54a56

…e view

swap to using a more constant value

dc1a58a

Merge branch 'main' into gh-eng-870-default-to-all-branches-when-no-c…

6b237c4

…overage-on-default-branch-on-commits-page

it should be a lowercase I

1b26076

fix tests

85f85a3

adrian-codecov approved these changes Dec 11, 2023

View reviewed changes

nicholas-codecov added 3 commits December 12, 2023 12:24

Merge branch 'main' into gh-eng-870-default-to-all-branches-when-no-c…

303a2a2

…overage-on-default-branch-on-commits-page

Merge branch 'main' into gh-eng-870-default-to-all-branches-when-no-c…

a9c844f

…overage-on-default-branch-on-commits-page

Merge branch 'main' into gh-eng-870-default-to-all-branches-when-no-c…

fb7d6d5

…overage-on-default-branch-on-commits-page

nicholas-codecov merged commit 2751fa4 into main Dec 12, 2023
49 checks passed

nicholas-codecov deleted the gh-eng-870-default-to-all-branches-when-no-coverage-on-default-branch-on-commits-page branch December 12, 2023 17:10

calvin-codecov mentioned this pull request Aug 28, 2024

Update with branch param instead of search #3147

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Default to All branches when default branch has no commits - Round 2 #2449

feat: Default to All branches when default branch has no commits - Round 2 #2449

nicholas-codecov commented Dec 11, 2023

codecov-public-qa bot commented Dec 11, 2023 •

edited

Loading

codecov-qa bot commented Dec 11, 2023 •

edited

Loading

codecov bot commented Dec 11, 2023 •

edited

Loading

netlify bot commented Dec 11, 2023 •

edited

Loading

feat: Default to All branches when default branch has no commits - Round 2 #2449

feat: Default to All branches when default branch has no commits - Round 2 #2449

Conversation

nicholas-codecov commented Dec 11, 2023

Description

Notable Changes

Screenshots

codecov-public-qa bot commented Dec 11, 2023 • edited Loading

Codecov Report

codecov-qa bot commented Dec 11, 2023 • edited Loading

Codecov Report

codecov bot commented Dec 11, 2023 • edited Loading

Codecov Report

netlify bot commented Dec 11, 2023 • edited Loading

✅ Deploy Preview for gazebo-staging ready!

codecov-public-qa bot commented Dec 11, 2023 •

edited

Loading

codecov-qa bot commented Dec 11, 2023 •

edited

Loading

codecov bot commented Dec 11, 2023 •

edited

Loading

netlify bot commented Dec 11, 2023 •

edited

Loading