feat: Add components selector for commits tab (#857)(#858) #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mits impacted files tab
JerrySentry
commented
Dec 12, 2023
src/pages/CommitDetailPage/subRoute/FilesChangedTab/FilesChangedTab.tsx
Outdated
Show resolved
Hide resolved
JerrySentry
commented
Dec 12, 2023
src/pages/CommitDetailPage/subRoute/ComponentsSelector/ComponentsSelector.tsx
Show resolved
Hide resolved
JerrySentry
commented
Dec 12, 2023
src/pages/CommitDetailPage/subRoute/ComponentsSelector/ComponentsSelector.spec.tsx
Show resolved
Hide resolved
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2454 +/- ##
==========================================
- Coverage 98.14% 98.13% -0.01%
==========================================
Files 776 777 +1
Lines 9962 9994 +32
Branches 2539 2550 +11
==========================================
+ Hits 9777 9808 +31
- Misses 183 184 +1
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2454 +/- ##
==========================================
- Coverage 98.14% 98.13% -0.01%
==========================================
Files 776 777 +1
Lines 9962 9994 +32
Branches 2544 2550 +6
==========================================
+ Hits 9777 9808 +31
- Misses 183 184 +1
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2454 +/- ##
=====================================
Coverage 98.14 98.14
=====================================
Files 776 777 +1
Lines 9962 9994 +32
Branches 2493 2550 +57
=====================================
+ Hits 9777 9808 +31
- Misses 183 184 +1
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
JerrySentry
changed the title
src/pages/CommitDetailPage/subRoute/FilesChangedTab/FilesChangedTab.tsx
Outdated
Show resolved
Hide resolved
src/pages/CommitDetailPage/subRoute/FilesChangedTab/FilesChangedTable/FilesChangedTable.jsx
Show resolved
Hide resolved
rohitvinnakota-codecov
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a multi selector for filtering by components in the commits page and add filtering functionality to the impacted files commits page.
Screen.Recording.2023-12-13.at.2.28.44.PM.mov
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.