Update yml to YAML in text references #2455

rohitvinnakota-codecov · 2023-12-12T19:45:10Z

Description

This PR closes codecov/engineering-team#866. We are also changing all occurrences of yaml to uppercase.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov

The changes introduced in the commit appear to be purely text replacements, changing instances of 'yml' to 'yaml'. There are no functional changes. While this change doesn't affect the functionality of the system itself, it might help to provide consistency in language and nomenclature for better user understanding.

src/pages/AccountSettings/tabs/YAML/YAML.jsx

src/pages/CommitDetailPage/UploadsCard/UploadsCard.jsx

codecov · 2023-12-12T19:46:11Z

...age/SettingsTab/tabs/GeneralTab/Tokens/ImpactAnalysisToken/RegenerateProfilingTokenModal.jsx

@@ -16,7 +16,7 @@ const RegenerateProfilingTokenModal = ({
    body={
      <div className="flex  flex-col gap-4">
        <h2 className="font-semibold">Impact Analysis</h2>
-        <p>If you save the new token, make sure to update your CI yml</p>
+        <p>If you save the new token, make sure to update your CI yaml</p>


'yaml' is referenced here in all lowercase which can look less professional compared to its CamelCase or uppercase equivalent 'YAML'. As this is user facing text, I recommend standardizing the usage of 'YAML' across your application in order to maintain consistency.

netlify · 2023-12-12T19:51:20Z

✅ Deploy Preview for gazebo-staging ready!

Name	Link
🔨 Latest commit	`02b608f`
🔍 Latest deploy log	https://app.netlify.com/sites/gazebo-staging/deploys/6578b8693ac43200081a1a2b
😎 Deploy Preview	https://deploy-preview-2455--gazebo-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-12-12T19:55:43Z

✅ Deploy Preview for gazebo-staging ready!

Name	Link
🔨 Latest commit	`2d74306`
🔍 Latest deploy log	https://app.netlify.com/sites/gazebo-staging/deploys/6578d86044c71d00084c53ad
😎 Deploy Preview	https://deploy-preview-2455--gazebo-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov

CodecovAI submitted a new review for f024cf1

src/pages/CommitDetailPage/UploadsCard/UploadsCard.jsx

codecov · 2023-12-12T20:01:17Z

Codecov Report

Merging #2455 (2d74306) into main (396a695) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2455   +/-   ##
=====================================
  Coverage   98.10   98.10           
=====================================
  Files        767     767           
  Lines       9786    9786           
  Branches    2428    2474   +46     
=====================================
  Hits        9600    9600           
  Misses       184     184           
  Partials       2       2

Files	Coverage Δ
...ngs/tabs/Admin/ManageAdminCard/ManageAdminCard.jsx	`100.00% <ø> (ø)`
...ntSettings/tabs/YAML/SuccessModal/SuccessModal.jsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/YAML/YAML.jsx	`100.00% <ø> (ø)`
...pages/CommitDetailPage/UploadsCard/UploadsCard.jsx	`100.00% <ø> (ø)`
src/pages/CommitDetailPage/YamlModal/YamlModal.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/CoverageTab/Summary/Summary.jsx	`100.00% <ø> (ø)`
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx	`100.00% <ø> (ø)`
...actAnalysisToken/RegenerateProfilingTokenModal.jsx	`100.00% <ø> (ø)`
...ab/Tokens/RepoUploadToken/RegenerateTokenModal.jsx	`100.00% <ø> (ø)`
...StaticAnalysisToken/RegenerateStaticTokenModal.jsx	`100.00% <ø> (ø)`
... and 3 more

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`97.30% <ø> (ø)`
Pages	`98.96% <100.00%> (ø)`
Services	`99.44% <ø> (ø)`
Shared	`99.81% <ø> (ø)`
UI	`94.32% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396a695...2d74306. Read the comment docs.

codecov

CodecovAI submitted a new review for 3a44a9f

src/pages/CommitDetailPage/UploadsCard/UploadsCard.spec.jsx

...age/SettingsTab/tabs/GeneralTab/Tokens/ImpactAnalysisToken/RegenerateProfilingTokenModal.jsx

src/pages/RepoPage/SettingsTab/tabs/GeneralTab/Tokens/RepoUploadToken/RegenerateTokenModal.jsx

src/pages/RepoPage/SettingsTab/tabs/GeneralTab/Tokens/RepoUploadToken/RepoUploadToken.spec.jsx

...poPage/SettingsTab/tabs/GeneralTab/Tokens/StaticAnalysisToken/RegenerateStaticTokenModal.jsx

...RepoPage/SettingsTab/tabs/GeneralTab/Tokens/StaticAnalysisToken/StaticAnalysisToken.spec.jsx

codecov-public-qa · 2023-12-12T20:06:59Z

Codecov Report

Merging #2455 (2d74306) into main (396a695) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2455   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         767      767           
  Lines        9786     9786           
  Branches     2474     2474           
=======================================
  Hits         9600     9600           
  Misses        184      184           
  Partials        2        2

Files	Coverage Δ
...ngs/tabs/Admin/ManageAdminCard/ManageAdminCard.jsx	`100.00% <ø> (ø)`
...ntSettings/tabs/YAML/SuccessModal/SuccessModal.jsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/YAML/YAML.jsx	`100.00% <ø> (ø)`
...pages/CommitDetailPage/UploadsCard/UploadsCard.jsx	`100.00% <ø> (ø)`
src/pages/CommitDetailPage/YamlModal/YamlModal.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/CoverageTab/Summary/Summary.jsx	`100.00% <ø> (ø)`
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx	`100.00% <ø> (ø)`
...actAnalysisToken/RegenerateProfilingTokenModal.jsx	`100.00% <ø> (ø)`
...ab/Tokens/RepoUploadToken/RegenerateTokenModal.jsx	`100.00% <ø> (ø)`
...StaticAnalysisToken/RegenerateStaticTokenModal.jsx	`100.00% <ø> (ø)`
... and 3 more

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`97.30% <ø> (ø)`
Pages	`98.96% <100.00%> (ø)`
Services	`99.44% <ø> (ø)`
Shared	`99.81% <ø> (ø)`
UI	`94.32% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396a695...2d74306. Read the comment docs.

codecov-qa · 2023-12-12T20:07:05Z

Codecov Report

Merging #2455 (2d74306) into main (396a695) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2455   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         767      767           
  Lines        9786     9786           
  Branches     2460     2430   -30     
=======================================
  Hits         9600     9600           
  Misses        184      184           
  Partials        2        2

Files	Coverage Δ
...ngs/tabs/Admin/ManageAdminCard/ManageAdminCard.jsx	`100.00% <ø> (ø)`
...ntSettings/tabs/YAML/SuccessModal/SuccessModal.jsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/YAML/YAML.jsx	`100.00% <ø> (ø)`
...pages/CommitDetailPage/UploadsCard/UploadsCard.jsx	`100.00% <ø> (ø)`
src/pages/CommitDetailPage/YamlModal/YamlModal.jsx	`100.00% <ø> (ø)`
src/pages/RepoPage/CoverageTab/Summary/Summary.jsx	`100.00% <ø> (ø)`
...ge/CoverageTab/SummaryTeamPlan/SummaryTeamPlan.tsx	`100.00% <ø> (ø)`
...actAnalysisToken/RegenerateProfilingTokenModal.jsx	`100.00% <ø> (ø)`
...ab/Tokens/RepoUploadToken/RegenerateTokenModal.jsx	`100.00% <ø> (ø)`
...StaticAnalysisToken/RegenerateStaticTokenModal.jsx	`100.00% <ø> (ø)`
... and 3 more

Components	Coverage Δ
Assets	`59.37% <ø> (ø)`
Layouts	`97.30% <ø> (ø)`
Pages	`98.96% <100.00%> (ø)`
Services	`99.44% <ø> (ø)`
Shared	`99.81% <ø> (ø)`
UI	`94.32% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396a695...2d74306. Read the comment docs.

codecov

CodecovAI submitted a new review for bdbda25

...RepoPage/SettingsTab/tabs/GeneralTab/Tokens/ImpactAnalysisToken/ImpactAnalysisToken.spec.jsx

nicholas-codecov

Looks all good to me 👍

rohitvinnakota-codecov force-pushed the rvinnakota/update-yaml-refs branch from 49b52fe to 02b608f Compare December 12, 2023 19:45

codecov bot reviewed Dec 12, 2023

View reviewed changes

rohitvinnakota-codecov changed the title ~~Update yml to YAML/yaml in text references~~ Update yml to YAML in text references Dec 12, 2023

rohitvinnakota-codecov force-pushed the rvinnakota/update-yaml-refs branch from 5ce7d36 to f024cf1 Compare December 12, 2023 19:57

codecov bot reviewed Dec 12, 2023

View reviewed changes

src/pages/CommitDetailPage/UploadsCard/UploadsCard.jsx Show resolved Hide resolved

rohitvinnakota-codecov force-pushed the rvinnakota/update-yaml-refs branch from f024cf1 to 3a44a9f Compare December 12, 2023 20:01

codecov bot reviewed Dec 12, 2023

View reviewed changes

...RepoPage/SettingsTab/tabs/GeneralTab/Tokens/ImpactAnalysisToken/ImpactAnalysisToken.spec.jsx Show resolved Hide resolved

rohitvinnakota-codecov force-pushed the rvinnakota/update-yaml-refs branch from 3972970 to 40a3bb6 Compare December 12, 2023 21:27

rohitvinnakota-codecov added 6 commits December 12, 2023 16:28

update yml to yaml in code

eedded7

uppercase

c1696db

Bunch of YAMLs

b9638d3

More updates

80a5bbb

Update test

c2b8fda

update team file

6e2ebcf

rohitvinnakota-codecov force-pushed the rvinnakota/update-yaml-refs branch from 40a3bb6 to 6e2ebcf Compare December 12, 2023 21:28

rohitvinnakota-codecov marked this pull request as ready for review December 12, 2023 21:33

nicholas-codecov approved these changes Dec 12, 2023

View reviewed changes

Merge branch 'main' into rvinnakota/update-yaml-refs

2d74306

rohitvinnakota-codecov merged commit aa54260 into main Dec 12, 2023
49 checks passed

rohitvinnakota-codecov deleted the rvinnakota/update-yaml-refs branch December 12, 2023 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update yml to YAML in text references #2455

Update yml to YAML in text references #2455

rohitvinnakota-codecov commented Dec 12, 2023 •

edited

Loading

codecov bot left a comment

codecov bot Dec 12, 2023 •

edited

Loading

rohitvinnakota-codecov Dec 12, 2023

netlify bot commented Dec 12, 2023

netlify bot commented Dec 12, 2023 •

edited

Loading

codecov bot left a comment

codecov bot commented Dec 12, 2023 •

edited

Loading

codecov bot left a comment

codecov-public-qa bot commented Dec 12, 2023 •

edited

Loading

codecov-qa bot commented Dec 12, 2023 •

edited

Loading

codecov bot left a comment

nicholas-codecov left a comment

Update yml to YAML in text references #2455

Update yml to YAML in text references #2455

Conversation

rohitvinnakota-codecov commented Dec 12, 2023 • edited Loading

Description

Legal Boilerplate

codecov bot left a comment

Choose a reason for hiding this comment

codecov bot Dec 12, 2023 • edited Loading

Choose a reason for hiding this comment

rohitvinnakota-codecov Dec 12, 2023

Choose a reason for hiding this comment

netlify bot commented Dec 12, 2023

✅ Deploy Preview for gazebo-staging ready!

netlify bot commented Dec 12, 2023 • edited Loading

✅ Deploy Preview for gazebo-staging ready!

codecov bot left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 12, 2023 • edited Loading

Codecov Report

codecov bot left a comment

Choose a reason for hiding this comment

codecov-public-qa bot commented Dec 12, 2023 • edited Loading

Codecov Report

codecov-qa bot commented Dec 12, 2023 • edited Loading

Codecov Report

codecov bot left a comment

Choose a reason for hiding this comment

nicholas-codecov left a comment

Choose a reason for hiding this comment

rohitvinnakota-codecov commented Dec 12, 2023 •

edited

Loading

codecov bot Dec 12, 2023 •

edited

Loading

netlify bot commented Dec 12, 2023 •

edited

Loading

codecov bot commented Dec 12, 2023 •

edited

Loading

codecov-public-qa bot commented Dec 12, 2023 •

edited

Loading

codecov-qa bot commented Dec 12, 2023 •

edited

Loading