Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix z index of flags selector #2462

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: Fix z index of flags selector #2462

merged 1 commit into from
Dec 18, 2023

Conversation

RulaKhaled
Copy link
Contributor

Description

before and after:
Screenshot 2023-12-18 at 2 24 50 PM
Screenshot 2023-12-18 at 2 35 25 PM

it's conflicting with flags multi selector, we're going to resolve this problem when we move the rest of the stuff down a to the gray box anyway.

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled changed the title fix: Fix z of flags selector fix: Fix z index of flags selector Dec 18, 2023
@codecov-staging
Copy link

codecov-staging bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2462   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         777      777           
  Lines        9993     9993           
  Branches     2554     2554           
=======================================
  Hits         9807     9807           
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
src/ui/MultiSelect/MultiSelect.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c411df6...5f31588. Read the comment docs.

Copy link

codecov-public-qa bot commented Dec 18, 2023

Codecov Report

Merging #2462 (5f31588) into main (c411df6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2462   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         777      777           
  Lines        9993     9993           
  Branches     2503     2549   +46     
=======================================
  Hits         9807     9807           
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
src/ui/MultiSelect/MultiSelect.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c411df6...5f31588. Read the comment docs.

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 5f31588
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65804be1485fa40007327dc5
😎 Deploy Preview https://deploy-preview-2462--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-qa
Copy link

codecov-qa bot commented Dec 18, 2023

Codecov Report

Merging #2462 (5f31588) into main (c411df6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2462   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         777      777           
  Lines        9993     9993           
  Branches     2554     2505   -49     
=======================================
  Hits         9807     9807           
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
src/ui/MultiSelect/MultiSelect.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.99% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.32% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c411df6...5f31588. Read the comment docs.

@RulaKhaled RulaKhaled merged commit 2f6b0fd into main Dec 18, 2023
49 checks passed
@RulaKhaled RulaKhaled deleted the fix-flags-selector branch December 18, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants