Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Place components selector in commit details file explorer #2466

Merged

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Description

Adds component selector to the file explorer in the commit detail page. This PR closes codecov/engineering-team#860.

Screen.Recording.2023-12-19.at.12.30.23.PM.mov

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Dec 19, 2023

Codecov Report

Merging #2466 (9a6245c) into main (16ba049) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2466   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         777      777           
  Lines        9993     9999    +6     
  Branches     2505     2539   +34     
=======================================
+ Hits         9807     9813    +6     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <100.00%> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.jsx 100.00% <100.00%> (ø)
...ble/TableEntries/CommitEntries/CommitFileEntry.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.98% <100.00%> (+<0.01%) ⬆️
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.48% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ba049...9a6245c. Read the comment docs.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit becaefa
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6581d3f22893550007020ab3
😎 Deploy Preview https://deploy-preview-2466--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review December 19, 2023 17:42
Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 9a6245c
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6581dd112dc51700082b40e4
😎 Deploy Preview https://deploy-preview-2466--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2466   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         777      777           
  Lines        9993     9999    +6     
  Branches     2549     2553    +4     
=======================================
+ Hits         9807     9813    +6     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <100.00%> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.jsx 100.00% <100.00%> (ø)
...ble/TableEntries/CommitEntries/CommitFileEntry.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.98% <100.00%> (+<0.01%) ⬆️
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.48% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ba049...9a6245c. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16ba049) 98.13% compared to head (9a6245c) 98.13%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2466   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         777      777           
  Lines        9993     9999    +6     
  Branches     2554     2539   -15     
=======================================
+ Hits         9807     9813    +6     
  Misses        184      184           
  Partials        2        2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <100.00%> (ø)
...ontents/commit/file/usePrefetchCommitFileEntry.tsx 100.00% <100.00%> (ø)
...able/TableEntries/CommitEntries/CommitDirEntry.jsx 100.00% <100.00%> (ø)
...ble/TableEntries/CommitEntries/CommitFileEntry.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 97.30% <ø> (ø)
Pages 98.98% <100.00%> (+<0.01%) ⬆️
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.48% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ba049...9a6245c. Read the comment docs.

@rohitvinnakota-codecov rohitvinnakota-codecov merged commit 7d01c2b into main Dec 19, 2023
49 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/add-components-commit-file-explorer branch December 19, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gazebo] Place the new multi selector *in commit details* files explorer tab
2 participants