feat: Grab the plugin name for the given bundle #3535

nicholas-codecov · 2024-11-28T15:00:25Z

Description

This PR updates the query options for grabbing a list of assets used to display the asset table, so that we can determine if we want to render the new path column in the asset table

Closes codecov/engineering-team#2957

Notable Changes

Grab plugin name in assets table query options
- also updated to be the TSQ V5 style we're moving to
Update useBundleAssetsTable
Update tests

codecov · 2024-11-28T15:02:42Z

Bundle Report

Changes will increase total bundle size by 388 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	5.67MB	81 bytes (0.0%) ⬆️
gazebo-production-system-esm	5.72MB	307 bytes (0.01%) ⬆️

codecov-staging · 2024-11-28T15:02:45Z

Bundle Report

Changes will increase total bundle size by 388 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm	5.72MB	307 bytes (0.01%) ⬆️
gazebo-staging-system	5.67MB	81 bytes (0.0%) ⬆️

codecov-notifications · 2024-11-28T15:03:51Z

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	80.00%	1 Missing ⚠️

@@           Coverage Diff           @@
##             main    #3535   +/-   ##
=======================================
  Coverage   98.90%   98.91%           
=======================================
  Files         806      806           
  Lines       14485    14484    -1     
  Branches     4116     4108    -8     
=======================================
  Hits        14327    14327           
+ Misses        151      150    -1     
  Partials        7        7

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (ø)`
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	`97.29% <80.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.59% <100.00%> (ø)`
Services	`99.36% <80.00%> (+0.03%)`	⬆️
Shared	`99.33% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617411d...06e670d. Read the comment docs.

codecov-qa · 2024-11-28T15:03:51Z

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.91%. Comparing base (617411d) to head (06e670d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	80.00%	1 Missing ⚠️

@@           Coverage Diff           @@
##             main    #3535   +/-   ##
=======================================
  Coverage   98.90%   98.91%           
=======================================
  Files         806      806           
  Lines       14485    14484    -1     
  Branches     4116     4115    -1     
=======================================
  Hits        14327    14327           
+ Misses        151      150    -1     
  Partials        7        7

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (ø)`
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	`97.29% <80.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.59% <100.00%> (ø)`
Services	`99.36% <80.00%> (+0.03%)`	⬆️
Shared	`99.33% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617411d...06e670d. Read the comment docs.

codecov · 2024-11-28T15:04:05Z

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.91%. Comparing base (617411d) to head (06e670d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	80.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3535   +/-   ##
=======================================
  Coverage   98.90%   98.91%           
=======================================
  Files         806      806           
  Lines       14485    14484    -1     
  Branches     4116     4115    -1     
=======================================
  Hits        14327    14327           
+ Misses        151      150    -1     
  Partials        7        7

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (ø)`
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	`97.29% <80.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.59% <100.00%> (ø)`
Services	`99.36% <80.00%> (+0.03%)`	⬆️
Shared	`99.33% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617411d...06e670d. Read the comment docs.

codecov-releaser · 2024-11-28T15:06:18Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`bd44b3a`	Thu, 28 Nov 2024 15:06:18 GMT	Expired	Expired
`55a3612`	Fri, 06 Dec 2024 11:25:06 GMT	Expired	Expired
`7caad44`	Mon, 09 Dec 2024 15:33:40 GMT	Expired	Expired
`06e670d`	Thu, 12 Dec 2024 16:21:44 GMT	Cloud	Enterprise

calvin-codecov · 2024-12-12T16:13:48Z

src/pages/RepoPage/BundlesTab/BundleContent/AssetsTable/useBundleAssetsTable.ts

@@ -54,21 +55,23 @@ export function useBundleAssetsTable({
    }
  }, [overview?.oldestCommitAt, today, trend])

-  return useBundleAssets({


i like this change

codecov-public-qa · 2024-12-12T16:20:02Z

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.91%. Comparing base (617411d) to head (06e670d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	80.00%	1 Missing ⚠️

@@           Coverage Diff           @@
##             main    #3535   +/-   ##
=======================================
  Coverage   98.90%   98.91%           
=======================================
  Files         806      806           
  Lines       14485    14484    -1     
  Branches     4109     4108    -1     
=======================================
  Hits        14327    14327           
+ Misses        151      150    -1     
  Partials        7        7

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <100.00%> (ø)`
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
.../services/bundleAnalysis/BundleAssetsQueryOpts.tsx	`97.29% <80.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.59% <100.00%> (ø)`
Services	`99.36% <80.00%> (+0.03%)`	⬆️
Shared	`99.33% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617411d...06e670d. Read the comment docs.

nicholas-codecov force-pushed the gh-eng-2957-grab-the-bundle-framework-in-branch-bundle-summary branch from bd44b3a to 55a3612 Compare December 6, 2024 11:19

nicholas-codecov marked this pull request as ready for review December 6, 2024 11:19

nicholas-codecov force-pushed the gh-eng-2957-grab-the-bundle-framework-in-branch-bundle-summary branch from 55a3612 to 7caad44 Compare December 9, 2024 15:27

nicholas-codecov mentioned this pull request Dec 11, 2024

feat: Update AssetsTable to conditionally render file path column #3565

Merged

calvin-codecov approved these changes Dec 12, 2024

View reviewed changes

calvin-codecov reviewed Dec 12, 2024

View reviewed changes

nicholas-codecov added 5 commits December 12, 2024 11:15

request plugin name in the new info field and move to only query options

ac79257

update useBundleAssetsTable

9d7670d

update for TSQ V5 and grab new bundle info data

514a05d

update BundleContent

ff5df8e

update field name

06e670d

nicholas-codecov force-pushed the gh-eng-2957-grab-the-bundle-framework-in-branch-bundle-summary branch from 7caad44 to 06e670d Compare December 12, 2024 16:16

nicholas-codecov added this pull request to the merge queue Dec 12, 2024

Merged via the queue into main with commit ad05f89 Dec 12, 2024
54 of 62 checks passed

nicholas-codecov deleted the gh-eng-2957-grab-the-bundle-framework-in-branch-bundle-summary branch December 12, 2024 16:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Grab the plugin name for the given bundle #3535

feat: Grab the plugin name for the given bundle #3535

nicholas-codecov commented Nov 28, 2024

codecov bot commented Nov 28, 2024 •

edited

Loading

codecov-staging bot commented Nov 28, 2024 •

edited

Loading

codecov-notifications bot commented Nov 28, 2024 •

edited

Loading

codecov-qa bot commented Nov 28, 2024 •

edited

Loading

codecov bot commented Nov 28, 2024 •

edited

Loading

codecov-releaser commented Nov 28, 2024 •

edited

Loading

calvin-codecov Dec 12, 2024

codecov-public-qa bot commented Dec 12, 2024 •

edited

Loading

feat: Grab the plugin name for the given bundle #3535

feat: Grab the plugin name for the given bundle #3535

Conversation

nicholas-codecov commented Nov 28, 2024

Description

Notable Changes

codecov bot commented Nov 28, 2024 • edited Loading

Bundle Report

codecov-staging bot commented Nov 28, 2024 • edited Loading

Bundle Report

codecov-notifications bot commented Nov 28, 2024 • edited Loading

Codecov Report

codecov-qa bot commented Nov 28, 2024 • edited Loading

Codecov Report

codecov bot commented Nov 28, 2024 • edited Loading

Codecov Report

codecov-releaser commented Nov 28, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

calvin-codecov Dec 12, 2024

Choose a reason for hiding this comment

codecov-public-qa bot commented Dec 12, 2024 • edited Loading

Codecov Report

codecov bot commented Nov 28, 2024 •

edited

Loading

codecov-staging bot commented Nov 28, 2024 •

edited

Loading

codecov-notifications bot commented Nov 28, 2024 •

edited

Loading

codecov-qa bot commented Nov 28, 2024 •

edited

Loading

codecov bot commented Nov 28, 2024 •

edited

Loading

codecov-releaser commented Nov 28, 2024 •

edited

Loading

codecov-public-qa bot commented Dec 12, 2024 •

edited

Loading