Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate useEnterpriseAccountDetails to TS Query V5 #3571

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useEnterpriseAccountDetails to the queryOptions API version EnterpriseAccountDetailsQueryOpts

Ticket: codecov/engineering-team#2968

Notable Changes

  • Migrate useEnterpriseAccountDetails to EnterpriseAccountDetailsQueryOpts
  • Update usage in CurrentOrgPlan and AccountOrgs
  • Update tests

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-2968-migrate-useEnterpriseAccountDetails-to-tsqv5 branch from 54fc3c9 to 81f0690 Compare December 11, 2024 21:22
@codecov-staging
Copy link

codecov-staging bot commented Dec 11, 2024

Bundle Report

Changes will increase total bundle size by 140 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 71 bytes (0.0%) ⬆️
gazebo-staging-system 5.67MB 69 bytes (0.0%) ⬆️

Copy link

codecov bot commented Dec 11, 2024

Bundle Report

Changes will increase total bundle size by 140 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.67MB 69 bytes (0.0%) ⬆️
gazebo-production-system-esm 5.72MB 71 bytes (0.0%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3571   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14485    14485           
  Branches     4116     4109    -7     
=======================================
  Hits        14327    14327           
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <ø> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...gPlan/queries/EnterpriseAccountDetailsQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606eb5d...ce14be4. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (606eb5d) to head (ce14be4).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3571   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14485    14485           
  Branches     4109     4109           
=======================================
  Hits        14327    14327           
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <ø> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...gPlan/queries/EnterpriseAccountDetailsQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606eb5d...ce14be4. Read the comment docs.

Copy link

codecov-public-qa bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (606eb5d) to head (ce14be4).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3571   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14485    14485           
  Branches     4109     4116    +7     
=======================================
  Hits        14327    14327           
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <ø> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...gPlan/queries/EnterpriseAccountDetailsQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606eb5d...ce14be4. Read the comment docs.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (606eb5d) to head (ce14be4).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3571   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14485    14485           
  Branches     4109     4109           
=======================================
  Hits        14327    14327           
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <ø> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...gPlan/queries/EnterpriseAccountDetailsQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606eb5d...ce14be4. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Dec 11, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
81f0690 Wed, 11 Dec 2024 21:28:48 GMT Expired Expired
ce14be4 Wed, 11 Dec 2024 21:52:23 GMT Cloud Enterprise

Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little thing, lgtm otherwise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 7b9fe28 Dec 11, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2968-migrate-useEnterpriseAccountDetails-to-tsqv5 branch December 11, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants