-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty string initialPageParam breaking ReposTeamQueryOpts #3626
fix: empty string initialPageParam breaking ReposTeamQueryOpts #3626
Conversation
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3626 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14562
Branches 4148 4148
=======================================
Hits 14414 14414
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3626 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14562
Branches 4148 4148
=======================================
Hits 14414 14414
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3626 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14562
Branches 4148 4141 -7
=======================================
Hits 14414 14414
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3626 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14562
Branches 4148 4148
=======================================
Hits 14414 14414
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
This is a fix for https://codecov.sentry.io/issues/6188893438/events/77c5b5686ad5480a961cf02ff1c90828/
It seems that using an empty string as initialPageParam does not get along well with our pagination logic on the API side. We will revisit this when Nick is back in office and possibly do a better fix.