Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty string initialPageParam breaking ReposTeamQueryOpts #3626

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

spalmurray-codecov
Copy link
Contributor

This is a fix for https://codecov.sentry.io/issues/6188893438/events/77c5b5686ad5480a961cf02ff1c90828/

It seems that using an empty string as initialPageParam does not get along well with our pagination logic on the API side. We will revisit this when Nick is back in office and possibly do a better fix.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review January 3, 2025 21:10
@codecov-staging
Copy link

codecov-staging bot commented Jan 3, 2025

Bundle Report

Changes will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.06MB 4 bytes (0.0%) ⬆️
gazebo-staging-system 6.0MB 4 bytes (0.0%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3626   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14562           
  Branches     4148     4148           
=======================================
  Hits        14414    14414           
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/repos/ReposTeamQueryOpts.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722e18...28c9122. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (7722e18) to head (28c9122).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3626   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14562           
  Branches     4148     4148           
=======================================
  Hits        14414    14414           
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/repos/ReposTeamQueryOpts.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722e18...28c9122. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (7722e18) to head (28c9122).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3626   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14562           
  Branches     4148     4141    -7     
=======================================
  Hits        14414    14414           
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/repos/ReposTeamQueryOpts.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722e18...28c9122. Read the comment docs.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (7722e18) to head (28c9122).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3626   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14562           
  Branches     4148     4148           
=======================================
  Hits        14414    14414           
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/repos/ReposTeamQueryOpts.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722e18...28c9122. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 3, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
28c9122 Fri, 03 Jan 2025 21:16:31 GMT Expired Expired
28c9122 Fri, 03 Jan 2025 21:16:38 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Bundle Report

Changes will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 4 bytes (0.0%) ⬆️
gazebo-production-system-esm 6.06MB 4 bytes (0.0%) ⬆️

Merged via the queue into main with commit 324ff6c Jan 3, 2025
62 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-team-plan-repos-list-query branch January 3, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants