-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Cache Bundle Banner to Commits Page #3634
feat: Add Cache Bundle Banner to Commits Page #3634
Conversation
Bundle ReportChanges will increase total bundle size by 1.29kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3634 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 811 811
Lines 14543 14553 +10
Branches 4127 4125 -2
=======================================
+ Hits 14395 14405 +10
Misses 141 141
Partials 7 7
... and 6 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3634 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 811 811
Lines 14543 14553 +10
Branches 4127 4125 -2
=======================================
+ Hits 14395 14405 +10
Misses 141 141
Partials 7 7
... and 6 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3634 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 811 811
Lines 14543 14553 +10
Branches 4120 4125 +5
=======================================
+ Hits 14395 14405 +10
Misses 141 141
Partials 7 7
... and 6 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3634 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 811 811
Lines 14543 14553 +10
Branches 4127 4132 +5
=======================================
+ Hits 14395 14405 +10
Misses 141 141
Partials 7 7
... and 6 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 1.16kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Description
This PR adds in the newly added cached bundles banner to the commits page behind a feature flag so that we can roll it out together once the work has been done for the pulls page.
Ticket: codecov/engineering-team#3153
Notable Changes
Screenshots
Note
These screenshots are forced as there aren't any examples on staging where caching is enabled.
Coverage and BA enabled:
BA only: