Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Cache Bundle Banner to Commits Page #3634

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in the newly added cached bundles banner to the commits page behind a feature flag so that we can roll it out together once the work has been done for the pulls page.

Ticket: codecov/engineering-team#3153

Notable Changes

  • Add banner to commit bundle component behind a feature flag
  • Add in tests

Screenshots

Note

These screenshots are forced as there aren't any examples on staging where caching is enabled.

Coverage and BA enabled:

Screenshot 2025-01-06 at 14 47 07

BA only:

Screenshot 2025-01-06 at 14 47 44

@codecov-staging
Copy link

codecov-staging bot commented Jan 6, 2025

Bundle Report

Changes will increase total bundle size by 1.29kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.06MB 771 bytes (0.01%) ⬆️
gazebo-staging-system 6.0MB 515 bytes (0.01%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (d88bff4) to head (28da2f2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3634   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         811      811           
  Lines       14543    14553   +10     
  Branches     4127     4125    -2     
=======================================
+ Hits        14395    14405   +10     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88bff4...28da2f2. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3634   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         811      811           
  Lines       14543    14553   +10     
  Branches     4127     4125    -2     
=======================================
+ Hits        14395    14405   +10     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88bff4...28da2f2. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (d88bff4) to head (28da2f2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3634   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         811      811           
  Lines       14543    14553   +10     
  Branches     4120     4125    +5     
=======================================
+ Hits        14395    14405   +10     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88bff4...28da2f2. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
28da2f2 Mon, 06 Jan 2025 18:55:45 GMT Cloud Enterprise

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (d88bff4) to head (28da2f2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3634   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         811      811           
  Lines       14543    14553   +10     
  Branches     4127     4132    +5     
=======================================
+ Hits        14395    14405   +10     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88bff4...28da2f2. Read the comment docs.

Copy link

codecov bot commented Jan 6, 2025

Bundle Report

Changes will increase total bundle size by 1.16kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 500 bytes (0.01%) ⬆️
gazebo-production-system-esm 6.06MB 661 bytes (0.01%) ⬆️

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 23e4bfd Jan 7, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3153-add-bundle-cache-banner-to-commits-page branch January 7, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants