Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: useRepoForTokensTeam to TS Query V5 #3657

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates useRepoForTokensTeam to the queryOptions API version RepoForTokensTeamQueryOpts, and updates GeneralTab to use the updated setup. As well, this PR includes a TS refactor for GeneralTab and it's tests bringing those up to date as well.

Ticket: codecov/engineering-team#2967

Notable Changes

  • Migrate useRepoForTokensTeam to RepoForTokensTeamQueryOpts
  • Refactor GeneralTab to use RepoForTokensTeamQueryOpts, and also refactor to TS
  • Update tests

Copy link

codecov bot commented Jan 14, 2025

Bundle Report

Changes will increase total bundle size by 259 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.05MB 132 bytes (0.0%) ⬆️
gazebo-production-esm 6.1MB 127 bytes (0.0%) ⬆️

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (8480fc7) to head (99b07df).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3657   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14716    14716           
  Branches     4173     4173           
=======================================
  Hits        14557    14557           
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
.../RepoPage/ConfigTab/tabs/GeneralTab/GeneralTab.tsx 100.00% <100.00%> (ø)
.../GeneralTab/queries/RepoForTokensTeamQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (ø)
Services 99.28% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8480fc7...99b07df. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3657   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14716    14716           
  Branches     4173     4173           
=======================================
  Hits        14557    14557           
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
.../RepoPage/ConfigTab/tabs/GeneralTab/GeneralTab.tsx 100.00% <100.00%> (ø)
.../GeneralTab/queries/RepoForTokensTeamQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (ø)
Services 99.28% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8480fc7...99b07df. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (8c7e9aa) to head (736fdca).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3657   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         814      814           
  Lines       14611    14611           
  Branches     4150     4150           
=======================================
  Hits        14456    14456           
  Misses        148      148           
  Partials        7        7           
Files with missing lines Coverage Δ
.../RepoPage/ConfigTab/tabs/GeneralTab/GeneralTab.tsx 100.00% <100.00%> (ø)
.../GeneralTab/queries/RepoForTokensTeamQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.64% <100.00%> (ø)
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7e9aa...736fdca. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (8480fc7) to head (99b07df).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3657   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14716    14716           
  Branches     4173     4165    -8     
=======================================
  Hits        14557    14557           
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
.../RepoPage/ConfigTab/tabs/GeneralTab/GeneralTab.tsx 100.00% <100.00%> (ø)
.../GeneralTab/queries/RepoForTokensTeamQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (ø)
Services 99.28% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8480fc7...99b07df. Read the comment docs.

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-2967-ref-useRepoForTokensTeam-to-tsq-v5 branch from 736fdca to 99b07df Compare January 20, 2025 11:21
@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
99b07df Mon, 20 Jan 2025 11:27:09 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit c9c56e6 Jan 20, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2967-ref-useRepoForTokensTeam-to-tsq-v5 branch January 20, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants