Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: useCoverageTabData to TS Query V5 #3658

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ref: useCoverageTabData to TS Query V5 #3658

wants to merge 2 commits into from

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useCoverageTabData hook to the queryOptions API version CoverageTabDataQueryOpts, as well as moving the calling of useRepoOverview out to the OverviewTab component.

Ticket: codecov/engineering-team#2967

Notable Changes

  • Migrates useCoverageTabData to CoverageTabDataQueryOpts
  • Update usage in OverviewTab
  • Update tests

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5643 1 5642 3
View the top 1 failed tests by shortest run time 
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx > UpgradeForm > when rendered > when the user has a basic plan > renders the organization and owner titles
Stack Traces | 1.37s run time 
TestingLibraryElementError: Unable to find an element with the text: /Organization/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div />
</body>

Ignored nodes: comments, script, style
<body>
  <div />
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx:403:48

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-staging
Copy link

codecov-staging bot commented Jan 14, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5643 1 5642 3
View the top 1 failed tests by shortest run time 
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx > UpgradeForm > when rendered > when the user has a basic plan > renders the organization and owner titles
Stack Traces | 1.37s run time 
TestingLibraryElementError: Unable to find an element with the text: /Organization/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div />
</body>

Ignored nodes: comments, script, style
<body>
  <div />
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx:403:48

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 14, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5643 1 5642 3
View the top 1 failed tests by shortest run time 
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx > UpgradeForm > when rendered > when the user has a basic plan > renders the organization and owner titles
Stack Traces | 1.37s run time 
TestingLibraryElementError: Unable to find an element with the text: /Organization/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div />
</body>

Ignored nodes: comments, script, style
<body>
  <div />
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx:403:48

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-public-qa Codecov Public QA
Copy link

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4174 1 4173 0
View the top 1 failed tests by shortest run time 
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx > UpgradeForm > when rendered > when the user has a basic plan > renders the organization and owner titles
Stack Traces | 1.37s run time 
TestingLibraryElementError: Unable to find an element with the text: /Organization/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div />
</body>

Ignored nodes: comments, script, style
<body>
  <div />
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx:403:48

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 72 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.04MB 35 bytes (-0.0%) ⬇️
gazebo-production-esm 6.09MB 37 bytes (-0.0%) ⬇️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
a2dedbb Tue, 14 Jan 2025 17:20:11 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suejung-sentry suejung-sentry suejung-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @suejung-sentry