Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: useCoverageTabData to TS Query V5 #3658

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useCoverageTabData hook to the queryOptions API version CoverageTabDataQueryOpts, as well as moving the calling of useRepoOverview out to the OverviewTab component.

Ticket: codecov/engineering-team#2967

Notable Changes

  • Migrates useCoverageTabData to CoverageTabDataQueryOpts
  • Update usage in OverviewTab
  • Update tests

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (8480fc7) to head (3df8fc0).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3658   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14716    14716           
  Branches     4173     4165    -8     
=======================================
  Hits        14557    14557           
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
...s/RepoPage/CoverageTab/OverviewTab/OverviewTab.tsx 100.00% <100.00%> (ø)
...b/OverviewTab/queries/CoverageTabDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (ø)
Services 99.28% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8480fc7...3df8fc0. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3658   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14716    14716           
  Branches     4173     4165    -8     
=======================================
  Hits        14557    14557           
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
...s/RepoPage/CoverageTab/OverviewTab/OverviewTab.tsx 100.00% <100.00%> (ø)
...b/OverviewTab/queries/CoverageTabDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (ø)
Services 99.28% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8480fc7...3df8fc0. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (8480fc7) to head (3df8fc0).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3658   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14716    14716           
  Branches     4173     4173           
=======================================
  Hits        14557    14557           
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
...s/RepoPage/CoverageTab/OverviewTab/OverviewTab.tsx 100.00% <100.00%> (ø)
...b/OverviewTab/queries/CoverageTabDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (ø)
Services 99.28% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8480fc7...3df8fc0. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (8480fc7) to head (3df8fc0).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3658   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14716    14716           
  Branches     4173     4165    -8     
=======================================
  Hits        14557    14557           
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
...s/RepoPage/CoverageTab/OverviewTab/OverviewTab.tsx 100.00% <100.00%> (ø)
...b/OverviewTab/queries/CoverageTabDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (ø)
Services 99.28% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8480fc7...3df8fc0. Read the comment docs.

Copy link

codecov bot commented Jan 14, 2025

Bundle Report

Changes will decrease total bundle size by 69 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.05MB 37 bytes (-0.0%) ⬇️
gazebo-production-esm 6.1MB 32 bytes (-0.0%) ⬇️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 14, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
a2dedbb Tue, 14 Jan 2025 17:20:11 GMT Expired Expired
3df8fc0 Mon, 20 Jan 2025 11:29:31 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-2967-ref-useCoverageTabData-to-tsqv5 branch from a2dedbb to 3df8fc0 Compare January 20, 2025 11:24
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 56c06e7 Jan 20, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2967-ref-useCoverageTabData-to-tsqv5 branch January 20, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants