ref: Remove tier name, use isTeamPlan #3666
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3666 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 817 817
Lines 14720 14714 -6
Branches 4165 4171 +6
==========================================
- Hits 14561 14555 -6
Misses 152 152
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3666 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 817 817
Lines 14720 14714 -6
Branches 4165 4171 +6
==========================================
- Hits 14561 14555 -6
Misses 152 152
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3666 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 817 817
Lines 14720 14714 -6
Branches 4165 4163 -2
==========================================
- Hits 14561 14555 -6
Misses 152 152
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3666 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 817 817
Lines 14720 14714 -6
Branches 4173 4171 -2
==========================================
- Hits 14561 14555 -6
Misses 152 152
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 773 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
| }), | ||
| }) | ||
|
|
||
| export const TierNames = { |
There was a problem hiding this comment.
Should we move this const over to billing.ts to be with the other consts?
| provider: string | ||
| owner: string | ||
| } | ||
|
|
||
| const query = ` | ||
| query OwnerTier($owner: String!) { | ||
| query OwnerPlan($owner: String!) { |
There was a problem hiding this comment.
Should this query be called OwnerPlan or isTeamPlan?
The former implies this query does more than return isTeamPlan imo
There was a problem hiding this comment.
i think IsTeamPlan would make more sense yah
| setup({ tierValue, privateRepo }) | ||
| isTeamPlan | privateRepo | ||
| ${false} | ${true} | ||
| ${false} | ${false} |
There was a problem hiding this comment.
2 of these cases are the same now I believe
| @@ -149,3 +149,10 @@ export function lastTwoDigits(value: number | string) { | |||
| } | |||
| return null | |||
| } | |||
|
|
|||
| export const TierNames = { | |||
There was a problem hiding this comment.
nit: Can we move these to the top of the file with the other consts? 😅
Description
There's no need to fetch the tier name anymore; we should unify the queries to use isTeamPlan, as it's consistently used throughout the codebase.
Notable Changes
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.