Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow build time configuration of sunburst #3689

Merged
merged 2 commits into from
Jan 29, 2025
Merged

feat: Allow build time configuration of sunburst #3689

merged 2 commits into from
Jan 29, 2025

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in a new configuration var SUNBURST_ENABLED for build time to override the display of the sunburst chart.

Notable Changes

  • Add in new config var SUNBURST_ENABLED
  • Update OverviewTab to take into account of new build time variable

@codecov-staging
Copy link

codecov-staging bot commented Jan 29, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 276 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.22MB 139 bytes (0.0%) ⬆️
gazebo-staging-esm 6.27MB 137 bytes (0.0%) ⬆️

@codecov-staging
Copy link

codecov-staging bot commented Jan 29, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5642 1 5641 3
View the top 1 failed tests by shortest run time 
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx > UpgradeForm > when rendered > when the user has a basic plan > renders the organization and owner titles
Stack Traces | 1.62s run time 
TestingLibraryElementError: Unable to find an element with the text: /Organization/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div />
</body>

Ignored nodes: comments, script, style
<body>
  <div />
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx:403:48

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 29, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5642 1 5641 3
View the top 1 failed tests by shortest run time 
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx > UpgradeForm > when rendered > when the user has a basic plan > renders the organization and owner titles
Stack Traces | 1.62s run time 
TestingLibraryElementError: Unable to find an element with the text: /Organization/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div />
</body>

Ignored nodes: comments, script, style
<body>
  <div />
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../UpgradePlanPage/UpgradeForm/UpgradeForm.test.tsx:403:48

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (50da594) to head (057de9c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3689   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         824      824           
  Lines       14809    14811    +2     
  Branches     4198     4199    +1     
=======================================
+ Hits        14630    14632    +2     
  Misses        170      170           
  Partials        9        9
Files with missing lines Coverage Δ
src/config.js 95.45% <100.00%> (+0.45%) ⬆️
...s/RepoPage/CoverageTab/OverviewTab/OverviewTab.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.41% <100.00%> (ø)
Services 99.27% <ø> (ø)
Shared 99.36% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50da594...057de9c. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
057de9c Wed, 29 Jan 2025 12:52:05 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 173686a Jan 29, 2025
48 of 54 checks passed
@nicholas-codecov nicholas-codecov deleted the feat-allow-configuration-of-sunburst branch January 29, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov