Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ACH microdeposits handling #3693

Merged
merged 7 commits into from
Jan 31, 2025

fix tests

c12204b
Select commit
Loading
Failed to load commit list.
Merged

feat: Add ACH microdeposits handling #3693

fix tests
c12204b
Select commit
Loading
Failed to load commit list.
Codecov Public QA / codecov/project failed Jan 30, 2025 in 1s

90.32% (-8.46%) compared to e9ca127

View this Pull Request on Codecov

90.32% (-8.46%) compared to e9ca127

Details

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.32%. Comparing base (e9ca127) to head (c12204b).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...Routes/UpgradePlanPage/UpgradeForm/UpgradeForm.tsx 77.77% 4 Missing ⚠️
...s/UpgradePlanPage/UpgradeForm/UpgradeFormModal.tsx 75.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e9ca127) and HEAD (c12204b). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (e9ca127) HEAD (c12204b)
16 6
@@            Coverage Diff             @@
##             main    #3693      +/-   ##
==========================================
- Coverage   98.78%   90.32%   -8.46%     
==========================================
  Files         825      828       +3     
  Lines       14819    14875      +56     
  Branches     4203     4222      +19     
==========================================
- Hits        14639    13436    -1203     
- Misses        171     1269    +1098     
- Partials        9      170     +161     
Files with missing lines Coverage Δ
src/pages/PlanPage/PlanPage.tsx 100.00% <100.00%> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...essageStripeCallback/InfoMessageStripeCallback.tsx 100.00% <100.00%> (ø)
...outes/CurrentOrgPlan/useCurrentOrgPlanPageData.tsx 100.00% <100.00%> (ø)
...c/services/account/useUnverifiedPaymentMethods.tsx 100.00% <100.00%> (ø)
...s/UpgradePlanPage/UpgradeForm/UpgradeFormModal.tsx 75.00% <75.00%> (ø)
...Routes/UpgradePlanPage/UpgradeForm/UpgradeForm.tsx 88.57% <77.77%> (-11.43%) ⬇️

... and 162 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.34% <90.38%> (-0.06%) ⬇️
Services 85.57% <100.00%> (-13.70%) ⬇️
Shared 63.68% <ø> (-35.69%) ⬇️
UI 77.39% <ø> (-21.69%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ca127...c12204b. Read the comment docs.