ref: Migrate useUpdateOktaConfig to TSQ V5 #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will decrease total bundle size by 244 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Bundle ReportChanges will decrease total bundle size by 244 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3697 +/- ##
==========================================
+ Coverage 98.75% 98.76% +0.01%
==========================================
Files 828 828
Lines 14875 14872 -3
Branches 4230 4226 -4
==========================================
- Hits 14690 14689 -1
+ Misses 176 174 -2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3697 +/- ##
==========================================
+ Coverage 98.71% 98.73% +0.01%
==========================================
Files 828 828
Lines 14891 14888 -3
Branches 4229 4225 -4
==========================================
- Hits 14700 14699 -1
+ Misses 182 180 -2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3697 +/- ##
==========================================
+ Coverage 98.71% 98.73% +0.01%
==========================================
Files 828 828
Lines 14891 14888 -3
Branches 4229 4225 -4
==========================================
- Hits 14700 14699 -1
+ Misses 182 180 -2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3697 +/- ##
==========================================
+ Coverage 98.71% 98.73% +0.01%
==========================================
Files 828 828
Lines 14891 14888 -3
Branches 4237 4233 -4
==========================================
- Hits 14700 14699 -1
+ Misses 182 180 -2
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Comment on lines
+20
to
+28
| __typename | ||
| ... on UnauthorizedError { | ||
| message | ||
| } | ||
| ... on ValidationError { | ||
| message | ||
| } | ||
| ... on UnauthenticatedError { | ||
| message |
There was a problem hiding this comment.
Because __typename is a valid field on every GQL type, if we define it in the top here, it will be automatically included in all of the spread for the different union types.
Comment on lines
+34
to
+47
| const ErrorUnionSchema = z.discriminatedUnion('__typename', [ | ||
| z.object({ | ||
| __typename: z.literal('UnauthorizedError'), | ||
| message: z.string(), | ||
| }), | ||
| z.object({ | ||
| __typename: z.literal('ValidationError'), | ||
| message: z.string(), | ||
| }), | ||
| z.object({ | ||
| __typename: z.literal('UnauthenticatedError'), | ||
| message: z.string(), | ||
| }), | ||
| ]) |
There was a problem hiding this comment.
Updated to use a discriminatedUnion because it is significantly more efficient over union. discriminatedUnion uses the first argument as the "check" field to match the the value being parsed instead of iterating over every single field to find the correct type.
You can read more about discriminatedUnion here
There was a problem hiding this comment.
I thought i'd also bring this out into it's own type, just to make things look a little cleaner.
Comment on lines
-122
to
-126
| if ( | ||
| error.__typename === 'ValidationError' || | ||
| error.__typename === 'UnauthorizedError' || | ||
| error.__typename === 'UnauthenticatedError' | ||
| ) { |
There was a problem hiding this comment.
I removed this error, because after testing if the mutation is successful then error is null, so we should show the toast if error is defined.
spalmurray-codecov
approved these changes
Jan 31, 2025
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
nicholas-codecov
deleted the
gh-eng-2963-migrate-useUpdateOktaConfig-to-tsq-v5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates
useUpdateOktaConfigto TSQ V5, and tidies up some logic within the hook.Ticket: codecov/engineering-team#2963
Notable Changes
useUpdateOktaConfigto use TSQ V5useUpdateOktaConfigtestsOktaConfigFormto useProvidertype (as it was updated as the arg to be passed inuseUpdateOktaConfig)