-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Migrate useSunburstCoverage to TSQ V5 #3701
ref: Migrate useSunburstCoverage to TSQ V5 #3701
Conversation
Bundle ReportChanges will increase total bundle size by 4.3kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 4.3kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
+ Coverage 98.75% 98.84% +0.08%
==========================================
Files 828 826 -2
Lines 14876 14872 -4
Branches 4222 4232 +10
==========================================
+ Hits 14691 14700 +9
+ Misses 176 166 -10
+ Partials 9 6 -3
... and 15 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
+ Coverage 98.75% 98.84% +0.08%
==========================================
Files 828 826 -2
Lines 14876 14872 -4
Branches 4222 4232 +10
==========================================
+ Hits 14691 14700 +9
+ Misses 176 166 -10
+ Partials 9 6 -3
... and 15 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
+ Coverage 98.75% 98.84% +0.08%
==========================================
Files 828 826 -2
Lines 14876 14872 -4
Branches 4230 4224 -6
==========================================
+ Hits 14691 14700 +9
+ Misses 176 166 -10
+ Partials 9 6 -3
... and 15 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
+ Coverage 98.75% 98.84% +0.08%
==========================================
Files 828 826 -2
Lines 14876 14872 -4
Branches 4230 4232 +2
==========================================
+ Hits 14691 14700 +9
+ Misses 176 166 -10
+ Partials 9 6 -3
... and 15 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR migrates
useSunburstCoverage
toSunburstCoverageQueryOpts
, as well a couple refactors to bring some old JS up to snuff with TS.Ticket: codecov/engineering-team#3165
Notable Changes
useSunburstCoverage
toSunburstCoverageQueryOpts
useSunburstChart
and TS refactor