feat: Update to send users developer instead of users basic #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 36 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 36 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3702 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 828 828
Lines 14888 14888
Branches 4225 4225
=======================================
Hits 14699 14699
Misses 180 180
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3702 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 828 828
Lines 14888 14888
Branches 4225 4225
=======================================
Hits 14699 14699
Misses 180 180
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3702 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 828 828
Lines 14888 14888
Branches 4233 4225 -8
=======================================
Hits 14699 14699
Misses 180 180
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3702 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 828 828
Lines 14888 14888
Branches 4225 4225
=======================================
Hits 14699 14699
Misses 180 180
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
ajay-sentry
reviewed
Feb 3, 2025
| isFreePlan: planValue === Plans.USERS_BASIC, | ||
| isFreePlan: | ||
| planValue === Plans.USERS_DEVELOPER || | ||
| planValue === Plans.USERS_BASIC, |
There was a problem hiding this comment.
if none of the tests are using USERS_BASIC anymore, can we clean up this check? Similarly with any other references we might have
There was a problem hiding this comment.
i guess it'll be good if i just add another test for basic? since we technically still support the plan
ajay-sentry
reviewed
Feb 3, 2025
| @@ -235,7 +235,7 @@ describe('PlanUpgradeTeam', () => { | |||
| ) | |||
| } | |||
|
|
|||
| describe('when rendered with basic plan', () => { | |||
| describe('when rendered with developers plan', () => { | |||
| it('shows the monthly marketing name', async () => { | |||
| setup({ plan: mockPlanBasic }) | |||
There was a problem hiding this comment.
nit: is it possible to do a find and replace for mockPlanBasic too? Or similar fuzzy find
ajay-sentry
reviewed
Feb 3, 2025
| @@ -323,7 +323,7 @@ describe('PlanUpgradeTeam', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('when rendered with non-basic plan', () => { | |||
| describe('when rendered with non-developers plan', () => { | |||
There was a problem hiding this comment.
this should really be "non-free" or "paid"
RulaKhaled
commented
Feb 3, 2025
| @@ -72,7 +72,7 @@ function SpecialOffer() { | |||
| Yes, I'd like 6 months with 30% discount | |||
| </Button> | |||
| <A variant="black" to={{ pageName: 'downgradePlanPage' }}> | |||
| No thanks, I'll proceed to the basic plan | |||
| No thanks, I'll proceed to the developers plan | |||
There was a problem hiding this comment.
We're proceeding with developers plan on downgrades
RulaKhaled
commented
Feb 3, 2025
| @@ -20,7 +20,7 @@ function cancelPlan({ provider, owner, planType }) { | |||
|
|
|||
| export function useCancelPlan({ provider, owner }) { | |||
| const queryClient = useQueryClient() | |||
| const planType = Plans.USERS_BASIC | |||
| const planType = Plans.USERS_DEVELOPER | |||
There was a problem hiding this comment.
We're sending the new plan type here
ajay-sentry
approved these changes
Feb 4, 2025
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're switching users to "developer" when canceling their current paid plan. This PR removes occurrences of "basic" where appropriate. However, the plan name will remain in the enum since we still support grandfathering the old free plan
Notable Changes
Screenshots
Nothing visual changes
Link to Sample Entry
Closes Add Reference to new Free Plan in Gazebo and Feature Flag
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.