fix: Test results not rendering on first pull branches with test data #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will decrease total bundle size by 97 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Bundle ReportChanges will decrease total bundle size by 97 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3710 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 828 828
Lines 14888 14888
Branches 4233 4225 -8
=======================================
Hits 14699 14699
Misses 180 180
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3710 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 828 828
Lines 14888 14888
Branches 4225 4233 +8
=======================================
Hits 14699 14699
Misses 180 180
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3710 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 828 828
Lines 14888 14888
Branches 4233 4233
=======================================
Hits 14699 14699
Misses 180 180
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
nicholas-codecov
deleted the
fix-branches-not-rendering-tests-when-there-are-tests-to-render
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a quick fix to allow rendering the test results when there are test results to be shown, but also this is the users first pull request. This issue was ran into, where there were test results uploaded on a branch, and no branches had been merged into main.
Examples:
Notable Changes
FailedTestsTablelogic to only show first pull message when first pull and no data to be rendered