ref: Migrate useBranchCoverageMeasurements to TSQ V5 #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholas-codecov
changed the title
Bundle ReportChanges will decrease total bundle size by 288 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
Files in
|
Bundle ReportChanges will decrease total bundle size by 288 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3711 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 826 826
Lines 14865 14862 -3
Branches 4223 4221 -2
==========================================
- Hits 14694 14691 -3
Misses 165 165
Partials 6 6
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3711 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 826 826
Lines 14865 14862 -3
Branches 4223 4229 +6
==========================================
- Hits 14694 14691 -3
Misses 165 165
Partials 6 6
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3711 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 826 826
Lines 14865 14862 -3
Branches 4231 4229 -2
==========================================
- Hits 14694 14691 -3
Misses 165 165
Partials 6 6
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3711 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 826 826
Lines 14865 14862 -3
Branches 4231 4221 -10
==========================================
- Hits 14694 14691 -3
Misses 165 165
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
ajay-sentry
reviewed
Feb 10, 2025
| }), | ||
| select: (data) => { | ||
| let coverage = [] | ||
| if (data.measurements?.[0]?.max === null) { |
There was a problem hiding this comment.
The optional chains are kinda throwing me off here because we're doing a hard set on the values in the line below 🤔
There was a problem hiding this comment.
This is validating that there is an entry in the array that has a field max on it that is null so that we can override the value. You're not able to use optional chaining while assigning a value.
There was a problem hiding this comment.
Yep I get that, it's a little unclear bc we're checking for null explicitly whereas if the value doesn't exist at any other point it'd return undefined. Just one of those "gotchas" / "landmines"
ajay-sentry
reviewed
Feb 10, 2025
src/pages/RepoPage/CoverageTab/OverviewTab/hooks/useRepoCoverageTimeseries.ts
Outdated
Show resolved
Hide resolved
ajay-sentry
reviewed
Feb 10, 2025
| @@ -65,7 +65,7 @@ function CoverageChart() { | |||
| ) | |||
| } | |||
|
|
|||
| if (data?.measurements.length < 1) { | |||
| if (!isPending && data?.measurements?.length < 1) { | |||
There was a problem hiding this comment.
do we need !isPending here?
There was a problem hiding this comment.
Yep, if it's not included then there's a type error
There was a problem hiding this comment.
Hrmrm, actually gonna switch this up a little bit.
There was a problem hiding this comment.
okay tidied things up
nicholas-codecov
deleted the
gh-eng-3165-ref-migrate-useBranchCoverageMeasurements-to-tsqv5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
useBranchCoverageMeasurementstoBranchCoverageMeasurementsQueryOptsTSQ V5 query options API.Ticket: codecov/engineering-team#3165
Notable Changes
useBranchCoverageMeasurementstoBranchCoverageMeasurementsQueryOptsuseRepoCoverageTimeseriesuseRepoCoverageTimeseriesinCoverageTrendandCoverageChart