fix: Update picker button colors for ACH on dark mode #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suejung-sentry
approved these changes
Feb 7, 2025
Bundle ReportChanges will decrease total bundle size by 74 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Bundle ReportChanges will decrease total bundle size by 74 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3714 +/- ##
==========================================
+ Coverage 98.83% 98.84% +0.01%
==========================================
Files 826 826
Lines 14858 14864 +6
Branches 4222 4222
==========================================
+ Hits 14685 14693 +8
+ Misses 167 165 -2
Partials 6 6
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3714 +/- ##
==========================================
+ Coverage 98.83% 98.84% +0.01%
==========================================
Files 826 826
Lines 14858 14864 +6
Branches 4230 4230
==========================================
+ Hits 14685 14693 +8
+ Misses 167 165 -2
Partials 6 6
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3714 +/- ##
==========================================
+ Coverage 98.83% 98.84% +0.01%
==========================================
Files 826 826
Lines 14858 14864 +6
Branches 4230 4222 -8
==========================================
+ Hits 14685 14693 +8
+ Misses 167 165 -2
Partials 6 6
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3714 +/- ##
==========================================
+ Coverage 98.83% 98.84% +0.01%
==========================================
Files 826 826
Lines 14858 14864 +6
Branches 4222 4222
==========================================
+ Hits 14685 14693 +8
+ Misses 167 165 -2
Partials 6 6
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ACH bank picker buttons were hard to read due to the background color of them previously. This PR updates that color to a lighter gray to make it easier to view. Also updates the text color to be darker as well, which I think is only the case on test mode, but just to be safe.
Closes codecov/engineering-team#3338
Screenshots
OLD
NEW - Dark Mode
Regression - Light Mode
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.