-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Set fetch-depth to 2 in our GHA examples #3800
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3800 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14970 14970
Branches 4273 4265 -8
=======================================
Hits 14781 14781
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3800 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14970 14970
Branches 4273 4265 -8
=======================================
Hits 14781 14781
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3800 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14970 14970
Branches 4273 4265 -8
=======================================
Hits 14781 14781
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportBundle size has no change ✅ |
We discussed this versus manually setting commit, but I think there are good arguments either way. We can come back to this, but will merge as fetch depth 2 is an improvement over the default fetch depth of 0. It also (indirectly and subtly) communicates to the user that fetch-depth 1 may not work for some reason. |
This PR sets all fetch-depths to 2 in our example github actions. This is something we say you need to do in our docs, but it wasn't reflected here.