Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Set fetch-depth to 2 in our GHA examples #3800

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

spalmurray-codecov
Copy link
Contributor

This PR sets all fetch-depths to 2 in our example github actions. This is something we say you need to do in our docs, but it wasn't reflected here.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review March 10, 2025 16:39
@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3800   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14970           
  Branches     4273     4265    -8     
=======================================
  Hits        14781    14781           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...ge/CoverageOnboarding/UseFrameworkInstructions.tsx 100.00% <ø> (ø)
...age/FailedTestsTab/GitHubActions/GitHubActions.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85c05...496521b. Read the comment docs.

Copy link

codecov-public-qa bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (7c85c05) to head (496521b).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3800   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14970           
  Branches     4273     4265    -8     
=======================================
  Hits        14781    14781           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...ge/CoverageOnboarding/UseFrameworkInstructions.tsx 100.00% <ø> (ø)
...age/FailedTestsTab/GitHubActions/GitHubActions.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85c05...496521b. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
496521b Mon, 10 Mar 2025 16:44:33 GMT Cloud Enterprise

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (7c85c05) to head (496521b).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3800   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14970           
  Branches     4273     4265    -8     
=======================================
  Hits        14781    14781           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...ge/CoverageOnboarding/UseFrameworkInstructions.tsx 100.00% <ø> (ø)
...age/FailedTestsTab/GitHubActions/GitHubActions.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85c05...496521b. Read the comment docs.

Copy link

codecov bot commented Mar 10, 2025

Bundle Report

Bundle size has no change ✅

@spalmurray-codecov
Copy link
Contributor Author

We discussed this versus manually setting commit, but I think there are good arguments either way. We can come back to this, but will merge as fetch depth 2 is an improvement over the default fetch depth of 0. It also (indirectly and subtly) communicates to the user that fetch-depth 1 may not work for some reason.

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 819dcd9 Mar 18, 2025
54 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fetch-depth branch March 18, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants