feat: Update login pageName to include redirect #3801

nicholas-codecov · 2025-03-10T16:55:41Z

Description

This PR updates the various locations in Gazebo where we are using a pageName: 'login', and updating them to include a to param of the current location. This will allow us to redirect the user from whatever page they are on after logging in with Codecov, streamlining the process for users to get back to where they were.

Closes: codecov/engineering-team#3452

Notable Changes

Update GuestHeader, CommitFileDiff x 2, PullFileDiff x 2, and RawFileViewer to include to redirect param
Update tests

codecov-staging · 2025-03-10T16:58:07Z

Bundle Report

Changes will increase total bundle size by 476 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system	6.11MB	239 bytes (0.0%) ⬆️
gazebo-staging-esm	6.18MB	237 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	73 bytes	125.01kB	0.06%
`assets/index.*.js`	72 bytes	125.71kB	0.06%
`assets/index.*.js`	55 bytes	638.95kB	0.01%
`assets/RawFileViewer.*.js`	37 bytes	126.86kB	0.03%

Files in assets/index.*.js:

./src/pages/CommitDetailPage/CommitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx → Total Size: 4.41kB
./src/pages/CommitDetailPage/CommitCoverage/routes/FilesChangedTab/shared/CommitFileDiff/CommitFileDiff.tsx → Total Size: 4.43kB

Files in assets/index.*.js:

./src/pages/PullRequestPage/PullCoverage/routes/FilesChangedTab/FilesChanged/PullFileDiff/PullFileDiff.tsx → Total Size: 3.81kB
./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx → Total Size: 3.79kB

Files in assets/index.*.js:

./src/layouts/Header/components/GuestHeader/GuestHeader.tsx → Total Size: 3.88kB

Files in assets/RawFileViewer.*.js:

./src/shared/RawFileViewer/RawFileViewer.tsx → Total Size: 3.55kB

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	74 bytes	113.71kB	0.07%
`assets/index-legacy.*.js`	74 bytes	113.12kB	0.07%
`assets/index-legacy.*.js`	55 bytes	717.68kB	0.01%
`assets/RawFileViewer-legacy.*.js`	36 bytes	127.09kB	0.03%

Files in assets/index-legacy.*.js:

./src/pages/CommitDetailPage/CommitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx → Total Size: 4.41kB
./src/pages/CommitDetailPage/CommitCoverage/routes/FilesChangedTab/shared/CommitFileDiff/CommitFileDiff.tsx → Total Size: 4.43kB

Files in assets/index-legacy.*.js:

./src/pages/PullRequestPage/PullCoverage/routes/FilesChangedTab/FilesChanged/PullFileDiff/PullFileDiff.tsx → Total Size: 3.81kB
./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx → Total Size: 3.79kB

Files in assets/index-legacy.*.js:

./src/layouts/Header/components/GuestHeader/GuestHeader.tsx → Total Size: 3.88kB

Files in assets/RawFileViewer-legacy.*.js:

./src/shared/RawFileViewer/RawFileViewer.tsx → Total Size: 3.55kB

codecov-notifications · 2025-03-10T16:59:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3801   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14976    +6     
  Branches     4273     4273           
=======================================
+ Hits        14781    14787    +6     
  Misses        182      182           
  Partials        7        7

Files with missing lines	Coverage Δ
...outs/Header/components/GuestHeader/GuestHeader.tsx	`100.00% <100.00%> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.61% <100.00%> (+0.05%)`	⬆️
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`97.67% <100.00%> (+0.05%)`	⬆️
...ngedTab/FilesChanged/PullFileDiff/PullFileDiff.tsx	`94.73% <100.00%> (+0.14%)`	⬆️
...s/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx	`94.73% <100.00%> (+0.14%)`	⬆️
src/shared/RawFileViewer/RawFileViewer.tsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.70% <100.00%> (+<0.01%)`	⬆️
Pages	`98.30% <100.00%> (+<0.01%)`	⬆️
Services	`99.38% <ø> (ø)`
Shared	`99.12% <100.00%> (+<0.01%)`	⬆️
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85c05...dd310af. Read the comment docs.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-public-qa · 2025-03-10T16:59:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (7c85c05) to head (dd310af).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3801   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14976    +6     
  Branches     4273     4273           
=======================================
+ Hits        14781    14787    +6     
  Misses        182      182           
  Partials        7        7

Files with missing lines	Coverage Δ
...outs/Header/components/GuestHeader/GuestHeader.tsx	`100.00% <100.00%> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.61% <100.00%> (+0.05%)`	⬆️
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`97.67% <100.00%> (+0.05%)`	⬆️
...ngedTab/FilesChanged/PullFileDiff/PullFileDiff.tsx	`94.73% <100.00%> (+0.14%)`	⬆️
...s/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx	`94.73% <100.00%> (+0.14%)`	⬆️
src/shared/RawFileViewer/RawFileViewer.tsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.70% <100.00%> (+<0.01%)`	⬆️
Pages	`98.30% <100.00%> (+<0.01%)`	⬆️
Services	`99.38% <ø> (ø)`
Shared	`99.12% <100.00%> (+<0.01%)`	⬆️
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85c05...dd310af. Read the comment docs.

codecov-releaser · 2025-03-10T17:01:23Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`dd310af`	Mon, 10 Mar 2025 17:01:23 GMT	Cloud	Enterprise

codecov · 2025-03-10T17:22:44Z

Bundle Report

Changes will increase total bundle size by 476 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	6.11MB	239 bytes (0.0%) ⬆️
gazebo-production-esm	6.18MB	237 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	73 bytes	125.01kB	0.06%
`assets/index.*.js`	55 bytes	638.95kB	0.01%
`assets/index.*.js`	72 bytes	125.71kB	0.06%
`assets/RawFileViewer.*.js`	37 bytes	126.86kB	0.03%

Files in assets/index.*.js:

./src/pages/CommitDetailPage/CommitCoverage/routes/FilesChangedTab/shared/CommitFileDiff/CommitFileDiff.tsx → Total Size: 4.43kB
./src/pages/CommitDetailPage/CommitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx → Total Size: 4.41kB

Files in assets/index.*.js:

./src/layouts/Header/components/GuestHeader/GuestHeader.tsx → Total Size: 3.88kB

Files in assets/index.*.js:

./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx → Total Size: 3.79kB
./src/pages/PullRequestPage/PullCoverage/routes/FilesChangedTab/FilesChanged/PullFileDiff/PullFileDiff.tsx → Total Size: 3.81kB

Files in assets/RawFileViewer.*.js:

./src/shared/RawFileViewer/RawFileViewer.tsx → Total Size: 3.55kB

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	74 bytes	113.71kB	0.07%
`assets/index-legacy.*.js`	55 bytes	717.68kB	0.01%
`assets/index-legacy.*.js`	74 bytes	113.12kB	0.07%
`assets/RawFileViewer-legacy.*.js`	36 bytes	127.09kB	0.03%

Files in assets/index-legacy.*.js:

./src/pages/CommitDetailPage/CommitCoverage/routes/IndirectChangesTab/IndirectChangesTable/CommitFileDiff/CommitFileDiff.tsx → Total Size: 4.41kB
./src/pages/CommitDetailPage/CommitCoverage/routes/FilesChangedTab/shared/CommitFileDiff/CommitFileDiff.tsx → Total Size: 4.43kB

Files in assets/index-legacy.*.js:

./src/layouts/Header/components/GuestHeader/GuestHeader.tsx → Total Size: 3.88kB

Files in assets/index-legacy.*.js:

./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx → Total Size: 3.79kB
./src/pages/PullRequestPage/PullCoverage/routes/FilesChangedTab/FilesChanged/PullFileDiff/PullFileDiff.tsx → Total Size: 3.81kB

Files in assets/RawFileViewer-legacy.*.js:

./src/shared/RawFileViewer/RawFileViewer.tsx → Total Size: 3.55kB

nicholas-codecov added 6 commits March 10, 2025 13:28

update GuestHeader component

4aca98e

update FilesChangedTab/CommitFileDiff login with redirect

e7bd71a

update IndirectChangesTab/CommitFileDiff login with redirect

fa41538

update FilesChangedTab/PullFileDiff login with redirect

eb7f84a

update IndirectChangesTab/PullFileDiff login with redirect

399752f

update login links in RawFileViewer

dd310af

nicholas-codecov marked this pull request as ready for review March 10, 2025 17:14

spalmurray-codecov approved these changes Mar 11, 2025

View reviewed changes

nicholas-codecov added this pull request to the merge queue Mar 11, 2025

Merged via the queue into main with commit 9699c04 Mar 11, 2025
51 of 54 checks passed

nicholas-codecov deleted the gh-eng-3452-feat-update-login-pageName-to-include-redirect branch March 11, 2025 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update login pageName to include redirect #3801

feat: Update login pageName to include redirect #3801

nicholas-codecov commented Mar 10, 2025

codecov-staging bot commented Mar 10, 2025 •

edited

Loading

Assets Changed:

Assets Changed:

codecov-notifications bot commented Mar 10, 2025 •

edited

Loading

codecov-public-qa bot commented Mar 10, 2025 •

edited

Loading

codecov-releaser commented Mar 10, 2025

codecov bot commented Mar 10, 2025

Assets Changed:

Assets Changed:

feat: Update login pageName to include redirect #3801

feat: Update login pageName to include redirect #3801

Conversation

nicholas-codecov commented Mar 10, 2025

Description

Notable Changes

codecov-staging bot commented Mar 10, 2025 • edited Loading

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

codecov-notifications bot commented Mar 10, 2025 • edited Loading

Codecov Report

codecov-public-qa bot commented Mar 10, 2025 • edited Loading

Codecov Report

codecov-releaser commented Mar 10, 2025

✅ Deploy preview for gazebo ready!

codecov bot commented Mar 10, 2025

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

codecov-staging bot commented Mar 10, 2025 •

edited

Loading

codecov-notifications bot commented Mar 10, 2025 •

edited

Loading

codecov-public-qa bot commented Mar 10, 2025 •

edited

Loading