Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update useBranches schema to make branches nullable #3802

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

Update the useBranches validation schema to make the branches field nullable, should help resolve this Sentry issue

Ticket: codecov/engineering-team#3385

@nicholas-codecov nicholas-codecov changed the title update schema to make branches nullable fix: Update useBranches schema to make branches nullable Mar 11, 2025
@codecov-staging
Copy link

codecov-staging bot commented Mar 11, 2025

Bundle Report

Changes will decrease total bundle size by 118 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.11MB -59 bytes (-0.0%) ⬇️
gazebo-staging-esm 6.18MB -59 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/useBranches-legacy.*.js -59 bytes 2.59kB -2.23%

Files in assets/useBranches-legacy.*.js:

  • ./src/services/branches/useBranches.tsx → Total Size: 3.73kB
view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/useBranches.*.js -59 bytes 2.91kB -1.99%

Files in assets/useBranches.*.js:

  • ./src/services/branches/useBranches.tsx → Total Size: 3.73kB

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3802   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14970           
  Branches     4273     4273           
=======================================
  Hits        14781    14781           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/branches/useBranches.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <100.00%> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85c05...176238b. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codecov-public-qa bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (7c85c05) to head (176238b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3802   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14970           
  Branches     4273     4273           
=======================================
  Hits        14781    14781           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/branches/useBranches.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <100.00%> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85c05...176238b. Read the comment docs.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (7c85c05) to head (176238b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3802   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14970           
  Branches     4273     4265    -8     
=======================================
  Hits        14781    14781           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/branches/useBranches.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <100.00%> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85c05...176238b. Read the comment docs.

Copy link

codecov bot commented Mar 11, 2025

Bundle Report

Changes will decrease total bundle size by 118 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.11MB -59 bytes (-0.0%) ⬇️
gazebo-production-esm 6.18MB -59 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/useBranches-legacy.*.js -59 bytes 2.59kB -2.23%

Files in assets/useBranches-legacy.*.js:

  • ./src/services/branches/useBranches.tsx → Total Size: 3.73kB
view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/useBranches.*.js -59 bytes 2.91kB -1.99%

Files in assets/useBranches.*.js:

  • ./src/services/branches/useBranches.tsx → Total Size: 3.73kB

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
176238b Tue, 11 Mar 2025 10:54:43 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 11, 2025
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 535feae Mar 11, 2025
54 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3385-fix-useBranches-branches-can-be-null branch March 11, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants