Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Convert BranchDirEntry to tsx #3810

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

spalmurray-codecov
Copy link
Contributor

Converts BranchDirEntry to tsx.

Part of codecov/engineering-team#2747

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review March 17, 2025 13:57
Copy link
Contributor

sentry-autofix bot commented Mar 17, 2025

✅ Sentry found no issues in your recent changes ✅

Copy link

codecov bot commented Mar 17, 2025

Bundle Report

Changes will decrease total bundle size by 444 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.11MB -211 bytes (-0.0%) ⬇️
gazebo-production-esm 6.19MB -233 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -233 bytes 89.12kB -0.26%

Files in assets/index.*.js:

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/useTypeSafeFilters.ts → Total Size: 751 bytes

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/BranchFileEntry.tsx → Total Size: 439 bytes

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/BranchDirEntry.tsx → Total Size: 369 bytes

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -211 bytes 83.89kB -0.25%

Files in assets/index-legacy.*.js:

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/useTypeSafeFilters.ts → Total Size: 751 bytes

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/BranchDirEntry.tsx → Total Size: 369 bytes

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/BranchFileEntry.tsx → Total Size: 439 bytes

@codecov-staging
Copy link

codecov-staging bot commented Mar 17, 2025

Bundle Report

Changes will decrease total bundle size by 444 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.11MB -211 bytes (-0.0%) ⬇️
gazebo-staging-esm 6.19MB -233 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -211 bytes 83.89kB -0.25%

Files in assets/index-legacy.*.js:

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/BranchDirEntry.tsx → Total Size: 369 bytes

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/useTypeSafeFilters.ts → Total Size: 751 bytes

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/BranchFileEntry.tsx → Total Size: 439 bytes

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -233 bytes 89.12kB -0.26%

Files in assets/index.*.js:

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/BranchFileEntry.tsx → Total Size: 439 bytes

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/useTypeSafeFilters.ts → Total Size: 751 bytes

  • ./src/shared/ContentsTable/TableEntries/BranchEntries/BranchDirEntry.tsx → Total Size: 369 bytes

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (ad46ee0) to head (880a60d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3810      +/-   ##
==========================================
- Coverage   98.73%   98.73%   -0.01%     
==========================================
  Files         826      827       +1     
  Lines       15001    14996       -5     
  Branches     4288     4286       -2     
==========================================
- Hits        14811    14806       -5     
  Misses        183      183              
  Partials        7        7              
Files with missing lines Coverage Δ
...ontentsTable/TableEntries/BaseEntries/DirEntry.tsx 100.00% <ø> (ø)
...able/TableEntries/BranchEntries/BranchDirEntry.tsx 100.00% <100.00%> (ø)
...ble/TableEntries/BranchEntries/BranchFileEntry.tsx 100.00% <ø> (ø)
...e/TableEntries/BranchEntries/useTypeSafeFilters.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.29% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <100.00%> (-0.01%) ⬇️
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad46ee0...880a60d. Read the comment docs.

Copy link

codecov-public-qa bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (ad46ee0) to head (880a60d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3810      +/-   ##
==========================================
- Coverage   98.73%   98.73%   -0.01%     
==========================================
  Files         826      827       +1     
  Lines       15001    14996       -5     
  Branches     4288     4278      -10     
==========================================
- Hits        14811    14806       -5     
  Misses        183      183              
  Partials        7        7              
Files with missing lines Coverage Δ
...ontentsTable/TableEntries/BaseEntries/DirEntry.tsx 100.00% <ø> (ø)
...able/TableEntries/BranchEntries/BranchDirEntry.tsx 100.00% <100.00%> (ø)
...ble/TableEntries/BranchEntries/BranchFileEntry.tsx 100.00% <ø> (ø)
...e/TableEntries/BranchEntries/useTypeSafeFilters.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.29% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <100.00%> (-0.01%) ⬇️
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad46ee0...880a60d. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
880a60d Mon, 17 Mar 2025 14:02:18 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 13291b7 Mar 17, 2025
54 of 55 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/convert-branch-dir-entry branch March 17, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants